Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: request and check metadata before downloading the kpm dependencies #301

Closed
liu-hm19 opened this issue Apr 22, 2024 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@liu-hm19
Copy link

Feature Request

Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

Please request and check metadata of the local kpm packages before downloading the kpm dependencies declared in kcl.mod, avoiding re-downloading the package due to the absence of the kcl.mod.lock file.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@Peefy Peefy added the enhancement New feature or request label Apr 22, 2024
@Peefy
Copy link
Contributor

Peefy commented Apr 23, 2024

Related Issue: #134

@Peefy
Copy link
Contributor

Peefy commented Apr 23, 2024

I personally believe that the following points need to be clarified:

  • Logic and checkpoints triggered by Git Source and OCI Source for re downloading.
  • How to compare the consistency between remote source and local package.
  • Do we need to check the local package checksum before running kcl? This may cause performance issues enhancement: kpm benchmark and improvement #295
  • How go and rust deals re downloading?

@zong-zhe
Copy link
Contributor

Addition

  • A redownload of one dependency may result in a redownload of an indirect dependency

@Peefy Peefy closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants