Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm fetch metadata during loading kcl.mod #332

Merged
merged 5 commits into from
May 24, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added bug Something isn't working enhancement New feature or request labels May 24, 2024
@zong-zhe zong-zhe requested a review from Peefy May 24, 2024 06:33
@zong-zhe zong-zhe self-assigned this May 24, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9221185028

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 43.142%

Files with Coverage Reduction New Missed Lines %
pkg/client/client.go 2 56.82%
Totals Coverage Status
Change from base Build 9219516125: -0.2%
Covered Lines: 2447
Relevant Lines: 5672

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants