Add cluster-aware dynamic client #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
force-pushed
the
dynamic-client
branch
3 times, most recently
from
6284ce4
to
3be52f0
Compare
ncdc
approved these changes
Jun 1, 2022
fabianvf
changed the title
fabianvf
force-pushed
the
dynamic-client
branch
8 times, most recently
from
2c2025c
to
f0d8c77
Compare
|
tests will be in a follow-up once we figure out how the boilerplate attribution for them will work, but it passed all the tests from kubernetes discovery client once they were modified to scope it to a cluster. Here's the tests we've run it through: https://github.com/fabianvf/apimachinery/compare/dynamic-client...fabianvf:dynamic-client-tests?expand=1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add
comments,tests, and verify implementation actually works at all