Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull-helm-charts-render presubmit to build:1.22.5-1 image #93

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

embik
Copy link
Member

@embik embik commented Jul 31, 2024

We are running a quite old build image in this presubmit, this updates it to the latest available ghcr.io/kcp-dev/infra/build image. It includes an update to Helm 3.15.3.

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kcp-ci-bot kcp-ci-bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jul 31, 2024
@embik embik changed the title Update pull-helm-charts-render presubmit to build:1.22.5-1 image Update pull-helm-charts-render presubmit to build:1.22.5-1 image Jul 31, 2024
@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2024
@embik embik requested review from xrstf and mjudeikis August 2, 2024 13:08
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6b38dac0e5bc4e8324bd9dc0b3f64a0426d17334

@embik
Copy link
Member Author

embik commented Aug 2, 2024

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@kcp-ci-bot kcp-ci-bot merged commit a8454bb into kcp-dev:main Aug 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants