Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --profiler-address to virtual workspace server and front proxy #1836

Closed
1 task
kylape opened this issue Aug 25, 2022 · 6 comments · Fixed by #2023
Closed
1 task

feat: add --profiler-address to virtual workspace server and front proxy #1836

kylape opened this issue Aug 25, 2022 · 6 comments · Fixed by #2023
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kylape
Copy link
Contributor

kylape commented Aug 25, 2022

Feature Description

This would be valuable to do memory profiling on more than just kcp.

Proposed Solution

Make the --profiler-address flag work on the VW and front proxy commands just like it does in kcp.

Alternative Solutions

No response

Want to contribute?

  • I would like to work on this issue.

Additional Context

No response

@ncdc
Copy link
Member

ncdc commented Aug 25, 2022

/help
/good-first-issue
/kind feature

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2022

@ncdc:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue
/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 25, 2022
@ncdc
Copy link
Member

ncdc commented Aug 25, 2022

See

kcp/pkg/server/config.go

Lines 153 to 156 in d3c2260

if opts.Extra.ProfilerAddress != "" {
// nolint:errcheck
go http.ListenAndServe(opts.Extra.ProfilerAddress, nil)
}

@bipuladh
Copy link
Contributor

I would like to take this if no one is working on this.

@ncdc
Copy link
Member

ncdc commented Aug 26, 2022

Please go ahead, thanks!

@ncdc
Copy link
Member

ncdc commented Aug 26, 2022

/assign @bipuladh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants