Support rebalancing Deployments across Clusters #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only creating leaf Deployments, also update and delete existing leafs. This means that as Clusters are added and become Ready, Deployments' replicas will be rebalanced across ready clusters, and as they get deleted or become un-Ready, they'll rebalance across ready clusters. Deployments will be re-reconciled when any Cluster is created, updated or deleted. This change also includes WIP support for DaemonSets and Pods though these aren't hooked up with controllers, only unit tests.
davidfestal
approved these changes
Aug 31, 2021
|
@imjasonh is this something we want to carry forward and eventually merge? |
Nope, I think we can drop this. The namespace scheduler will take over as the way to move deployments (and anything) around, and eventually deployment-splitter can just be deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only creating leaf Deployments, also update and delete
existing leafs. This means that as Clusters are added and become Ready,
Deployments' replicas will be rebalanced across ready clusters, and as
they get deleted or become un-Ready, they'll rebalance across ready
clusters.
This is incomplete: cluster creations/deletions/changes won't trigger
root deployment reconciliations as of this change.
This also adds unit tests and configures CI to run tests.
(Also fix some lint errors and style nits)
edit: This PR has also grown to include DaemonSet and Pod scheduling, not hooked up to any controller, to demonstrate how they'd work in unit tests. These are examples of different scheduling strategies we'd like to generalize and apply to other arbitrary types.