Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table-driven tests for schemacompat #126

Merged
merged 1 commit into from Aug 11, 2021
Merged

Conversation

imjasonh
Copy link
Contributor

@imjasonh imjasonh commented Jul 6, 2021

Split out from #121

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #126 (b2579e7) into main (cb67159) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   20.75%   20.75%           
=======================================
  Files           5        5           
  Lines         318      318           
=======================================
  Hits           66       66           
  Misses        237      237           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb67159...b2579e7. Read the comment docs.

Copy link
Member

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! We could even go one step further, and use test fixtures, like what had been done in repo https://github.com/devfile/api/blob/main/pkg/utils/overriding/overriding_test.go#L180 (see here to see the YAML files that define the tests. That's even more easy to read and contribute to.

@imjasonh imjasonh merged commit cddb817 into kcp-dev:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants