New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch demos tests with PR labeling #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thaanks for this!
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
=======================================
Coverage 21.98% 21.98%
=======================================
Files 5 5
Lines 323 323
=======================================
Hits 71 71
Misses 235 235
Partials 17 17 Continue to review full report at Codecov.
|
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@davidfestal I upgrade kind to 0.11.1 and I had some changes in the results. Can u check it, please? |
@flacatus Do you know why the demos are not run anymore on your PR though the label is there ? (is it because it's a WIP PR ?) |
Yes @davidfestal , I had the PR in WIP. Now seems is running the demos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think you could add a way to restart the demos with an instruction (something like /run-demos
?
Because the workflow dispatch
button option does not allow running the action from a fork, only from a branch of the current repo.
Being able to trigger it with such an instruction would help I assume
Repo owners can at least re-run the workflow, which is better than nothing. Unlabeling and relabeling should also trigger a rerun, if I understand correctly. |
The follow Pull Request launch demos on labeling pull request with
check-demos
.Signed-off-by: Flavius Lacatusu flacatus@redhat.com