Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch demos tests with PR labeling #181

Merged
merged 1 commit into from Oct 7, 2021
Merged

Conversation

flacatus
Copy link
Contributor

@flacatus flacatus commented Oct 6, 2021

The follow Pull Request launch demos on labeling pull request with check-demos.
Signed-off-by: Flavius Lacatusu flacatus@redhat.com

Copy link
Contributor

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaanks for this!

.github/workflows/demos.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #181 (246bb30) into main (2f1c4b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   21.98%   21.98%           
=======================================
  Files           5        5           
  Lines         323      323           
=======================================
  Hits           71       71           
  Misses        235      235           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1c4b9...246bb30. Read the comment docs.

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Contributor Author

flacatus commented Oct 7, 2021

@davidfestal I upgrade kind to 0.11.1 and I had some changes in the results. Can u check it, please?

@davidfestal
Copy link
Member

@flacatus Do you know why the demos are not run anymore on your PR though the label is there ? (is it because it's a WIP PR ?)

@flacatus flacatus marked this pull request as ready for review October 7, 2021 10:54
@flacatus
Copy link
Contributor Author

flacatus commented Oct 7, 2021

@flacatus Do you know why the demos are not run anymore on your PR though the label is there ? (is it because it's a WIP PR ?)

Yes @davidfestal , I had the PR in WIP. Now seems is running the demos.

@davidfestal davidfestal self-requested a review October 7, 2021 12:14
Copy link
Member

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you could add a way to restart the demos with an instruction (something like /run-demos ?
Because the workflow dispatch button option does not allow running the action from a fork, only from a branch of the current repo.
Being able to trigger it with such an instruction would help I assume

@imjasonh
Copy link
Contributor

imjasonh commented Oct 7, 2021

Repo owners can at least re-run the workflow, which is better than nothing. Unlabeling and relabeling should also trigger a rerun, if I understand correctly.

@imjasonh imjasonh merged commit f1145a6 into kcp-dev:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants