-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5. kubectl-kcp: get rid of workspace duality and implement logical cluster path semantics #778
5. kubectl-kcp: get rid of workspace duality and implement logical cluster path semantics #778
Conversation
c54cc88
to
398fa63
Compare
9851181
to
a705aa9
Compare
4ae5008
to
f8d398e
Compare
60ec028
to
c872c4a
Compare
c872c4a
to
75ae0a6
Compare
} | ||
newCluster := *oldCluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you don't manage AuthInfo at all in the current and previous context ?
Afair in previous tests I had done, it might bring some very painful behavior where you cannot bring back the auth used (through a --token override for example) with the previous workspace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think this needs to be carried forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on @sttts 's comment in Slack
verified that overrides don't affect what is persisted. This is what kubectl itself does too. overrides are only used to tweak a client used by kubectl/the plugin.
👍
9ccabd8
to
ace68a1
Compare
} | ||
newCluster := *oldCluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on @sttts 's comment in Slack
verified that overrides don't affect what is persisted. This is what kubectl itself does too. overrides are only used to tweak a client used by kubectl/the plugin.
👍
c72ec96
to
3983095
Compare
Implementing UX from https://docs.google.com/document/d/1XJJCr16bg22QuJnQB2W98A-djRTtrLr2JE2IWZUHzJU/edit#heading=h.nn8danthd1ys.
Workspaces
in some virtual workspace path and theClusterWorkspaces
in an org. Now you can dokubectl get workspaces
in an orgBased on #744.