5. kubectl-kcp: get rid of workspace duality and implement logical cluster path semantics #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
added
kind/feature
sttts
force-pushed
the
sttts-kcp-logicalcluster-kubectl-kcp
branch
from
c54cc88
to
398fa63
Compare
sttts
changed the title
sttts
changed the title
sttts
changed the title
sttts
changed the title
sttts
force-pushed
the
sttts-kcp-logicalcluster-kubectl-kcp
branch
2 times, most recently
from
9851181
to
a705aa9
Compare
sttts
changed the title
sttts
force-pushed
the
sttts-kcp-logicalcluster-kubectl-kcp
branch
3 times, most recently
from
4ae5008
to
f8d398e
Compare
Merged
sttts
force-pushed
the
sttts-kcp-logicalcluster-kubectl-kcp
branch
4 times, most recently
from
60ec028
to
c872c4a
Compare
sttts
force-pushed
the
sttts-kcp-logicalcluster-kubectl-kcp
branch
from
c872c4a
to
75ae0a6
Compare
ncdc
reviewed
Mar 29, 2022
davidfestal
reviewed
Mar 30, 2022
| } | ||
| newCluster := *oldCluster |
There was a problem hiding this comment.
So you don't manage AuthInfo at all in the current and previous context ?
Afair in previous tests I had done, it might bring some very painful behavior where you cannot bring back the auth used (through a --token override for example) with the previous workspace.
There was a problem hiding this comment.
Yes I think this needs to be carried forward
There was a problem hiding this comment.
Based on @sttts 's comment in Slack
verified that overrides don't affect what is persisted. This is what kubectl itself does too. overrides are only used to tweak a client used by kubectl/the plugin.
👍
sttts
force-pushed
the
sttts-kcp-logicalcluster-kubectl-kcp
branch
from
9ccabd8
to
ace68a1
Compare
davidfestal
reviewed
Mar 31, 2022
ncdc
reviewed
Mar 31, 2022
| } | ||
| newCluster := *oldCluster |
There was a problem hiding this comment.
Based on @sttts 's comment in Slack
verified that overrides don't affect what is persisted. This is what kubectl itself does too. overrides are only used to tweak a client used by kubectl/the plugin.
👍
ncdc
approved these changes
Mar 31, 2022
sttts
force-pushed
the
sttts-kcp-logicalcluster-kubectl-kcp
branch
from
c72ec96
to
3983095
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing UX from https://docs.google.com/document/d/1XJJCr16bg22QuJnQB2W98A-djRTtrLr2JE2IWZUHzJU/edit#heading=h.nn8danthd1ys.
Workspacesin some virtual workspace path and theClusterWorkspacesin an org. Now you can dokubectl get workspacesin an orgBased on #744.