Add Log4J xml parsing #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got tired of trying to decode xml-vomit in my head and made a snippet to paste into the console when opening GDL. Just decided to commit it so other people can have clean-looking logs too. Tested to work with 1.16+ - not sure about anything older.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Log4J xml-spam has been an issue since the RCE exploit that was discovered a while back. It makes logs incredibly difficult to quickly parse, which makes modpack debugging difficult.
Approach
We parse it! To be honest - mine is not the cleanest or quickest solution, but it functions very well, and since we were already using console.log anyways, it doesn't really have to be fast in the first place. Future revisions could probably speed it up quite a lot using regex, but that's beyond my skill in that field.
Open Questions and Pre-Merge TODOs
Learning
Other than double-checking a few things on MDN this was all done from the top of my head, in vanilla JS.