Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send: incremental send fails on / #122

Closed
mirco opened this issue Apr 10, 2018 · 2 comments
Closed

send: incremental send fails on / #122

mirco opened this issue Apr 10, 2018 · 2 comments
Labels
bug
Milestone
v4.17

Comments

@mirco
Copy link

mirco commented Apr 10, 2018

Pull Request #98 doesn't handle the case of mnt being / properly, causing incremental sends from the rootfs to fail with
ERROR: not on mount point: /
even if both the subvolume to send and the parent subvolume given with -p are located on /.

Steps to reproduce:

btrfs subvolume snapshot -r / /parent
btrfs subvolume snapshot -r / /child
btrfs send -p /parent /child > /dev/null
@MarkoSchuetz MarkoSchuetz mentioned this issue Apr 24, 2018
Open
@kdave kdave added the bug label May 8, 2018
@stralytic
Copy link

stralytic commented May 31, 2018 •
edited
Loading

I'm also having this problem with btrfs-progs 4.16.1 on ubuntu cosmic. Works fine on btrfs-progs 4.15.1 from bionic.

@kdave kdave added this to the v4.17 milestone May 31, 2018
@kdave
Copy link
Owner

kdave commented May 31, 2018

Fixed by #138 and will be released in 4.17.

@kdave kdave closed this as completed May 31, 2018
kdave pushed a commit that referenced this issue May 31, 2018
@digint @kdave
btrfs-progs: fix regression preventing send -p with subvolumes mounte…
ffc7e4f 
…d on "/"

Fix subvol_strip_mountpoint for mnt="/" (len=1). In this case, skip
check for trailing slash on full_path (leading slash on full_path is
already asserted by strncmp).

Issue: #122
Pull-request: #138
Fixes: c5dc299 ("btrfs-progs: prevent incorrect use of subvol_strip_mountpoint")
Signed-off-by: Axel Burri <axel@tty0.ch>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave pushed a commit that referenced this issue Jun 5, 2018
@digint @kdave
btrfs-progs: fix regression preventing send -p with subvolumes mounte…
98b38af 
…d on "/"

Fix subvol_strip_mountpoint for mnt="/" (len=1). In this case, skip
check for trailing slash on full_path (leading slash on full_path is
already asserted by strncmp).

Issue: #122
Pull-request: #138
Fixes: c5dc299 ("btrfs-progs: prevent incorrect use of subvol_strip_mountpoint")
Signed-off-by: Axel Burri <axel@tty0.ch>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave pushed a commit that referenced this issue Jun 7, 2018
@digint @kdave
btrfs-progs: fix regression preventing send -p with subvolumes mounte…
aabe8e7 
…d on "/"

Fix subvol_strip_mountpoint for mnt="/" (len=1). In this case, skip
check for trailing slash on full_path (leading slash on full_path is
already asserted by strncmp).

Issue: #122
Pull-request: #138
Fixes: c5dc299 ("btrfs-progs: prevent incorrect use of subvol_strip_mountpoint")
Signed-off-by: Axel Burri <axel@tty0.ch>
Signed-off-by: David Sterba <dsterba@suse.com>
kdave pushed a commit that referenced this issue Jun 7, 2018
@digint @kdave
btrfs-progs: fix regression preventing send -p with subvolumes mounte…
09827a8 
…d on "/"

Fix subvol_strip_mountpoint for mnt="/" (len=1). In this case, skip
check for trailing slash on full_path (leading slash on full_path is
already asserted by strncmp).

Issue: #122
Pull-request: #138
Fixes: c5dc299 ("btrfs-progs: prevent incorrect use of subvol_strip_mountpoint")
Signed-off-by: Axel Burri <axel@tty0.ch>
Signed-off-by: David Sterba <dsterba@suse.com>
@heftig heftig mentioned this issue Jan 19, 2019
Closed
@marcochiodo marcochiodo mentioned this issue Jan 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v4.17
Development

No branches or pull requests
3 participants
@mirco @kdave @stralytic