forked from OpenFeign/feignx
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
OpenFeignGH-57 Delegate Template Parameter creation to Method Handlers
Related to OpenFeign#57 This change moves `TemplateParameter` object creation to `AbstractTargetMethodHandler` to reduce the overhead of `Contract` parsing and reduce the responsibility of `Contract` implementations to class metadata and not collaborating object construction.
- Loading branch information
Showing
11 changed files
with
640 additions
and
94 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
194 changes: 194 additions & 0 deletions
194
core/src/main/java/feign/TargetMethodParameterDefinition.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,194 @@ | ||
| /* | ||
| * Copyright 2019-2021 OpenFeign Contributors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package feign; | ||
|
|
||
| import feign.support.Assert; | ||
| import java.util.Locale; | ||
| import java.util.Objects; | ||
| import java.util.StringJoiner; | ||
| import net.jcip.annotations.Immutable; | ||
| import net.jcip.annotations.ThreadSafe; | ||
|
|
||
| /** | ||
| * Definition of a Method Parameter on a Target Method. | ||
| */ | ||
| @ThreadSafe | ||
| @Immutable | ||
| public class TargetMethodParameterDefinition { | ||
|
|
||
| private final String name; | ||
| private final String type; | ||
| private final Integer index; | ||
| private final String expanderClassName; | ||
|
|
||
| public static Builder builder() { | ||
| return new Builder(); | ||
| } | ||
|
|
||
| /** | ||
| * Create a new {@link TargetMethodParameterDefinition}. | ||
| * | ||
| * @param name of the parameter. | ||
| * @param type of the parameter. | ||
| * @param index of the parameter in the method definition. | ||
| * @param expanderClassName of the expander to use when resolving this parameter. | ||
| */ | ||
| private TargetMethodParameterDefinition(String name, String type, Integer index, | ||
| String expanderClassName) { | ||
| Assert.isNotEmpty(name, "name is required."); | ||
| Assert.isNotEmpty(type, "type is required."); | ||
| Assert.isNotNull(index, "argument index is required."); | ||
| Assert.isTrue(index, idx -> idx >= 0, "argument index must be a positive number"); | ||
| Assert.isNotEmpty(expanderClassName, "expander class name is required."); | ||
| this.name = name; | ||
| this.type = type; | ||
| this.index = index; | ||
| this.expanderClassName = expanderClassName; | ||
| } | ||
|
|
||
| /** | ||
| * The Name of the Parameter. | ||
| * | ||
| * @return parameter name. | ||
| */ | ||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| /** | ||
| * Fully Qualified Class Name for the parameter type. | ||
| * | ||
| * @return parameter type. | ||
| */ | ||
| public String getType() { | ||
| return this.type; | ||
| } | ||
|
|
||
| /** | ||
| * Argument Index of the Parameter. | ||
| * | ||
| * @return the argument index. | ||
| */ | ||
| public Integer getIndex() { | ||
| return index; | ||
| } | ||
|
|
||
| /** | ||
| * Fully Qualified Class Name of the {@link feign.template.ExpressionExpander} to use when | ||
| * expanding this parameter value. | ||
| * | ||
| * @return the fully qualified class name. | ||
| */ | ||
| public String getExpanderClassName() { | ||
| return expanderClassName; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (this == obj) { | ||
| return true; | ||
| } | ||
| if (!(obj instanceof TargetMethodParameterDefinition)) { | ||
| return false; | ||
| } | ||
| TargetMethodParameterDefinition that = (TargetMethodParameterDefinition) obj; | ||
| return getName().equalsIgnoreCase(that.getName()) && getType().equals(that.getType()) | ||
| && getIndex().equals(that.getIndex()) | ||
| && getExpanderClassName().equals(that.getExpanderClassName()); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(getName(), getType(), getIndex(), getExpanderClassName()); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return new StringJoiner(", ", | ||
| TargetMethodParameterDefinition.class.getSimpleName() + "[", "]") | ||
| .add("name='" + name + "'") | ||
| .add("type='" + type + "'") | ||
| .add("index=" + index) | ||
| .add("expanderClassName='" + expanderClassName + "'") | ||
| .toString(); | ||
| } | ||
|
|
||
| /** | ||
| * Builder for a Target Method Parameter Definition. | ||
| */ | ||
| public static class Builder { | ||
|
|
||
| private String name; | ||
| private String type; | ||
| private Integer index; | ||
| private String expanderClassName; | ||
|
|
||
| /** | ||
| * Parameter Name. | ||
| * | ||
| * @param name of the parameter. | ||
| * @return a builder instance for chaining. | ||
| */ | ||
| public Builder name(String name) { | ||
| this.name = name; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Parameter Argument Index. | ||
| * | ||
| * @param index of the parameter in the method definition. | ||
| * @return a builder instance for chaining. | ||
| */ | ||
| public Builder index(Integer index) { | ||
| this.index = index; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Fully Qualified Class name of the parameter type. | ||
| * | ||
| * @param type of the parameter. | ||
| * @return a builder instance for chaining. | ||
| */ | ||
| public Builder type(String type) { | ||
| this.type = type; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Expression Expander Fully Qualified Class name to use when resolving this parameter value. | ||
| * | ||
| * @param expanderClassName of the {@link feign.template.ExpressionExpander} | ||
| * @return a builder instance for chaining. | ||
| */ | ||
| public Builder expanderClassName(String expanderClassName) { | ||
| this.expanderClassName = expanderClassName; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Create a new {@link TargetMethodParameterDefinition} from the builder properties. | ||
| * | ||
| * @return a new {@link TargetMethodParameterDefinition} instance. | ||
| */ | ||
| public TargetMethodParameterDefinition build() { | ||
| return new TargetMethodParameterDefinition(this.name, this.type, this.index, | ||
| this.expanderClassName); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.