Missing sub-directory in logged file name

[leggewie]

Preliminary checks

• I am running the latest version
• I have read the Code of Conduct
• I have checked there is not other Issues or Pull Requests covering the same topic to open

As you can see in #155 errors in files are being logged with the filename being logged as /home/user/Maildir/.Erledigt:1406922416.M923538P22149.giga,W=2249,S=2199 for example. That looks like the filepath, but it isn't quite it. First the path to the directory ends in : and not / as well as missing /cur/. Furthermore, the filename in this case lacks a few more characters :2,S. The correct and complete filenpath would be /home/user/Maildir/.Erledigt/cur/1406922416.M923538P22149.giga,W=2249,S=2199:2,S. This thwarts any attempts at copy and pasting the filepath to inspect the file directly.

Am I correct to assume this is not intended behaviour?

[kdeldycke]

You're right there is an issue here. As the mail source is a Maildir, we should expect the output to be real, fully-qualified path, and must indeed be allowed to be copy-pasted without effort.

The root cause should be somewhere around these lines:

mail-deduplicate/mail_deduplicate/mailbox.py

Lines 138 to 146 in f423b41

	path = Path(path)
	if not box_type:
	box_type = autodetect_box_type(path)
	else:
	logger.warning(f"Forcing {box_type} format.")
	constructor = BOX_TYPES[box_type]
	# Do not allow the constructor to create a new mailbox if not found.
	box = constructor(path, create=False)

. In which the recursive opening of maildir subfolders happens.

If you could come up with a fix, feel free to propose a PR! :)

[leggewie]

I'm not sure about that. I believe

mail-deduplicate/mail_deduplicate/mail.py

Lines 93 to 94 in f423b41

	def __repr__(self):
	return f"<{self.__class__.__name__} {self.source_path}:{self.mail_id}>"

is where it's at.

[leggewie]

Indeed, leggewie@62e3b1d results in a string that can be copied&pasted straight off the terminal. Obviously, it's not the right fix.

Questions:

• what is responsible for truncating file names after a : colon?
• why does source_path not include {tmp,cur,new}?
• how does this affect mailbox formats other than maildir?