build: take advantage of upstream static asset build improvements #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2023
kdmccormick
force-pushed
the
kdmccormick/new-assets
branch
2 times, most recently
from
ab2fe22
to
15355ae
Compare
kdmccormick
force-pushed
the
kdmccormick/new-assets
branch
8 times, most recently
from
88370fc
to
26d9cfa
Compare
This is a follow-up fix to overhangio#819, where the corresponding change was added to the mysqld invocation in the "tutor local" (that is, docker-compose) deployment method, but omitted from its "tutor k8s" equivalent.
Now that sphinx_rtd support docutils>=0.19 we can drop that max version requirement. But we need to limit sphinx max version because they removed python 3.8 support before EOL.
Type tests were broken following the upgrade of click. We take the opportunity to simplify the TutorCli implementation.
kdmccormick
force-pushed
the
kdmccormick/new-assets
branch
from
26d9cfa
to
1d2ca1d
Compare
TODOs: * describe commit * address TODOs in code * should it be `tutor dev populate-mounts` instead? * add to `tutor dev launch`? * circulate a TEP? Part of: TODO link ticket
kdmccormick
force-pushed
the
kdmccormick/new-assets
branch
2 times, most recently
from
8277e31
to
ed40169
Compare
This reverts commit 56c4ac8.
BuildKit replaces and improves the legacy Docker builder, which was deprecated back in Feb 2023. Assuming BuildKit allows us to simplify the Dockerfile and makes future build performance improvements easier. The Docker versions which Tutor recommends (v20+) all come with BuildKit, so As follow-up work, we will need to remove `is_buildkit_enabled` from the official plugins templates. Relevant discussion: overhangio#868 (comment)
TODOs: * See if we can reduce the huge mount blocks a bit. * Merge edx-platform asset folder changes instead of patching in a PR. * Add changelog entry. * Test more thoroughly. * Circulate a TEP or some other form of proposal? * Deprecate patches that no longer exist or have changed. Part of: https://github.com/openedx/wg-developer-experience/issues/166
TODO: * Changelog entry * Comments * Linting * Tests * TEP
kdmccormick
force-pushed
the
kdmccormick/new-assets
branch
from
ed40169
to
bb59612
Compare
|
Closed in favor of #34 |
kdmccormick
force-pushed
the
kdmccormick/buildkit
branch
from
449e5d8
to
1a3abf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #34
TODOs:
Part of: openedx/wg-devops#21