Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new edx-platform assets build + other improvements #34

Draft
wants to merge 55 commits into
base: nightly
Choose a base branch
from

Commits on Sep 1, 2023

  1. feat!: assume BuildKit is available

    BuildKit replaces and improves the legacy Docker builder, which was
    deprecated back in Feb 2023. Assuming BuildKit allows us to simplify the
    Dockerfile and makes future build performance improvements easier. The
    Docker versions which Tutor recommends (v20+) all come with BuildKit, so
    
    As follow-up work, we will need to remove `is_buildkit_enabled` from
    the official plugins templates.
    
    Relevant discussion:
    overhangio#868 (comment)
    kdmccormick committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    1a3abf8 View commit details
    Browse the repository at this point in the history
  2. build: take advantage of upstream static asset build improvements

    TODOs:
    * See if we can reduce the huge mount blocks a bit.
    * Merge edx-platform asset folder changes instead of patching in a PR.
    * Add changelog entry.
    * Test more thoroughly.
    * Circulate a TEP or some other form of proposal?
    * Deprecate patches that no longer exist or have changed.
    
    Part of: https://github.com/openedx/wg-developer-experience/issues/166
    kdmccormick committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    61862b3 View commit details
    Browse the repository at this point in the history
  3. feat: tutor dev/local copyartifacts

    TODO:
    * Changelog entry
    * Comments
    * Linting
    * Tests
    * TEP
    kdmccormick committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    1ec378f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Configuration menu
    Copy the full SHA
    eba2c77 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    b77ea64 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    f5c463b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    c28cc93 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    510b023 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82cdc5d View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Configuration menu
    Copy the full SHA
    7123b8c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    8c72f69 View commit details
    Browse the repository at this point in the history
  2. fix: build: re-install edx-platform in dev image

    copying in the dev virtualenv was clobbering the symlink which
    `pip install -e .` creates in the virtualenv.
    
    fixes this error in dev mode:
    
        Traceback (most recent call last):
          File "/openedx/bin/site-configuration", line 3, in <module>
    	import lms.startup
        ModuleNotFoundError: No module named 'lms'
    kdmccormick committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0378a77 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Configuration menu
    Copy the full SHA
    1d57cd8 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Configuration menu
    Copy the full SHA
    e9e590d View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Configuration menu
    Copy the full SHA
    ed519cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72a832a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e5b530 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. fix: RsaKey.dq attribute error

    Running `tutor config save` with an outdated version of pycryptodome was
    failing with the following error:
    
        Error: Missing configuration value: 'Crypto.PublicKey.RSA.RsaKey object' has no attribute 'dq'
    
    This is because the "dq" attribute was only introduced in pycryptodome
    3.17.0: https://www.pycryptodome.org/src/changelog#january-2023
    
    To resolve this issue we bump the minimum requirements.
    
    Close overhangio#962
    regisb authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a4e3155 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96a04db View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc9b2d6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6948586 View commit details
    Browse the repository at this point in the history
  5. docs: fix minor issues

    regisb authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    7879eff View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f2a5196 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    57e5712 View commit details
    Browse the repository at this point in the history
  8. ci: fix reference to personal access token

    Turns out, github.token is not a PAT
    actions/add-to-project#462 (comment)
    regisb authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    02ee7ff View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    44f52f8 View commit details
    Browse the repository at this point in the history
  10. docs: remove useless openedx hooks section

    That section was empty anyway.
    regisb authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c490c37 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    fdeb4b6 View commit details
    Browse the repository at this point in the history
  12. fix: correctly render .webp and .otf files in env

    This partially addresses overhangio#985.
    
    ---------
    
    Co-authored-by: Ravi Khetani <r.khetani@institute.global>
    2 people authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    7ea76e2 View commit details
    Browse the repository at this point in the history
  13. docs: fix google analytics example

    Fixed extra indentation for the Google Analytics plugin example. The extra indentation makes the plugin fail when being activated.
    Silidrone authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f0d4bd9 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7f95062 View commit details
    Browse the repository at this point in the history
  15. doc: update steps to release a new version

    close overhangio#983
    
    ---------
    
    Co-authored-by: Muhammad Faraz  Maqsood <faraz.maqsood@a006-01130.home>
    2 people authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    aece9b6 View commit details
    Browse the repository at this point in the history
  16. v17.0.1

    regisb authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4e6df39 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    2789740 View commit details
    Browse the repository at this point in the history
  18. fixup!: Apply review feedback

    xitij2000 authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    62973dc View commit details
    Browse the repository at this point in the history
  19. chore: remove useless test file

    This test fixture has been happily living in the test folder for 4
    years...
    regisb authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    70224a7 View commit details
    Browse the repository at this point in the history
  20. fix: save env on plugins enable

    Environment was not updated correctly on `tutor plugins enable ...`
    because of a caching issue. To bypass this issue, we improve the caching
    mechanism and introduce a new `lru_cache` decorator.
    
    Close overhangio#989.
    regisb authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d879573 View commit details
    Browse the repository at this point in the history
  21. chore: add missing test fixture and changelog entry

    We somehow forgot to include these files in a previous commit...
    regisb authored and kdmccormick committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    020787e View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    bf9fe93 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    dcab52d View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    dfb6d53 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Configuration menu
    Copy the full SHA
    d857612 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Configuration menu
    Copy the full SHA
    cc65425 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. feat!: remove dependency on Paver scripts

    BREAKING CHANGE: `openedx-assets` is replaed with `npm run` subcommands.
    For details, see the changelog entry.
    For further details and rationale, see the upstream DEPR ticket:
    openedx/edx-platform#31895
    kdmccormick committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f00c311 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    dc2ca3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b38354f View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    5f79206 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aba2af3 View commit details
    Browse the repository at this point in the history
  3. build: get rid of 'rm sass' line; optimization is not worth complexity

    It's a 50MB optimization, which is nice, but not worth these Dockerfile
    lines. This optimizatoin will happen naturally in Sumac, anyway, since
    Paver's deps will be removed from base.txt
    kdmccormick committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e46a58d View commit details
    Browse the repository at this point in the history
  4. style: tabs -> spaces

    kdmccormick committed May 20, 2024
    Configuration menu
    Copy the full SHA
    281c7b5 View commit details
    Browse the repository at this point in the history
  5. fix: chown /openedx app

    fixes permission error
    kdmccormick committed May 20, 2024
    Configuration menu
    Copy the full SHA
    eef1730 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a86e932 View commit details
    Browse the repository at this point in the history
  7. build: remove some --link

    kdmccormick committed May 20, 2024
    Configuration menu
    Copy the full SHA
    f13715f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8e6f523 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    072799b View commit details
    Browse the repository at this point in the history