Skip to content

Commit

Permalink
sheep: don't exit when sheep calls leave_cluster()
Browse files Browse the repository at this point in the history
When some unrecoverable error happens, sheep daemon will leave the cluster but stay
as a gate to redirect requests.

For e.g, fllowing case is sheep meets an EIO
...
Nov 24 10:36:15 do_io_request(785) failed: 2, 2, 7c2b2500000000 , 1, 3
Nov 24 10:36:15 io_op_done(147) leaving sheepdog cluster
Nov 24 10:36:15 sd_leave_handler(1291) network partition bug: this sheep should have exited
Nov 24 10:36:15 log_sigsegv(358) logger pid 8255 exiting abnormally
...

Thit has nothing to do with network partition stuff.

Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
Signed-off-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
  • Loading branch information
liuy authored and kazum committed Nov 24, 2011
1 parent fa30aa5 commit a2fd195
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions sheep/group.c
Original file line number Diff line number Diff line change
Expand Up @@ -1287,9 +1287,6 @@ static void sd_leave_handler(struct sheepdog_node_list_entry *left,
struct work_leave *w = NULL;
int i, size;

if (node_cmp(left, &sys->this_node) == 0)
panic("network partition bug: this sheep should have exited\n");

dprintf("leave %s\n", node_to_str(left));
for (i = 0; i < nr_members; i++)
dprintf("[%x] %s\n", i, node_to_str(members + i));
Expand Down

0 comments on commit a2fd195

Please sign in to comment.