Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alwaysTransition flag #201

Merged
merged 3 commits into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@gabzsa
Copy link
Contributor

commented Nov 15, 2018

Added always transition flag to ImageLoadingOptions, so that you can control whether to show transition even when image is retrieved from cache

Added always transition flag to ImageLoadingOptions, so that you can …
…control whether to show transition even when image is retrieved from cache
@kean

This comment has been minimized.

Copy link
Owner

commented Nov 15, 2018

@gabzsa thanks, looks good. I checked the CI report, the build is failing on macOS:

❌  /Users/travis/build/kean/Nuke/Sources/ImageView.swift:396:66: missing argument for parameter #5 in call
            _display(image, options.transition, fromMemCache, nil)

❌  /Users/travis/build/kean/Nuke/Sources/ImageView.swift:398:85: missing argument for parameter #5 in call
            _display(failureImage, options.failureImageTransition, fromMemCache, nil)
                 ^
❌  /Users/travis/build/kean/Nuke/Sources/ImageView.swift:405:55: missing argument for parameter #5 in call
        _display(image, options.transition, false, nil)

gabzsa added some commits Nov 15, 2018

@gabzsa

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

Sorry about that. Seems to be fixed.

@kean kean merged commit 65ec762 into kean:master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.