This repository has been archived by the owner on Oct 1, 2022. It is now read-only.
support video: more function #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Alexander-Foster
commented
Dec 24, 2021
Alexander-Foster
commented
- add video looping change function
- add video finish callback
- add restart video function
- add video looping change function - add video finish callback - add restart video function
|
Thanks for putting this together, @kor45cw. I'm going to review it as soon as I got some free time! |
|
I think it looks good. Thanks @kor45cw . |
kean
reviewed
Jan 27, 2022
| imageView.isVideoLooping = isVideoLooping | ||
| } | ||
| if restartVideo { | ||
| imageView.videoReplay() |
There was a problem hiding this comment.
The videoReplay call is missing. I'm going to remove it temporarily for the upcoming release.
There was a problem hiding this comment.
I changed it to restartVideo(). I think that's what you meant?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.