Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RTL languages #114

Closed
NaifAlrashed opened this issue Sep 18, 2022 · 3 comments
Closed

Add support for RTL languages #114

NaifAlrashed opened this issue Sep 18, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@NaifAlrashed
Copy link

when opening the ui in right to left languages, we have problems reading the interface. I included a pic for the most painful page, the viewer
IMG_7DC51DE45E89-1

@kean
Copy link
Owner

kean commented Sep 29, 2022

Thanks for the report. I would appreciate some help on this.

@kean kean added the bug Something isn't working label Sep 29, 2022
@kean
Copy link
Owner

kean commented Dec 31, 2022

I added a workaround for the JSON viewer in 2.2.0 where I hardcoded the language direction, so at least it's somewhat readable.

Screenshot 2022-12-30 at 7 57 01 PM

Unfortunately, I don't have experience supporting RTL languages. The app is also not localized and supports only English at the moment. I would appreciate some help adding proper support for RTL interfaces, and I'm open to adding localization support.

@kean kean added the enhancement New feature or request label Dec 31, 2022
@kean kean changed the title PulseUI issues in right to left languages Add support for RTL languages Dec 31, 2022
@kean kean removed the bug Something isn't working label Dec 31, 2022
@ARamy23
Copy link

ARamy23 commented Jul 2, 2023

I think this is a good solution for RTL languages, since the response will be read in English anyways and the content is not localized in anyway, so its okay if you indeed hardcoded the direction to be LTR-forced

kean added a commit that referenced this issue Feb 1, 2024
fix: Text writing direction to handle RTL languages (#114)
@kean kean closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants