Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Text writing direction to handle RTL languages (#114) #233

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Mr-Alirezaa
Copy link
Contributor

@Mr-Alirezaa Mr-Alirezaa commented Jan 23, 2024

Overview

This pull request addresses a text alignment issue in right-to-left (RTL) user interfaces within text view, specifically related to text being aligned at the trailing edge of text views. The problem is also detailed in Issue #114.

Solution

To resolve this, I have implemented a fix by setting the baseWritingDirection in the paragraph styles to override the default behavior.

Considerations

It's important to note that this fix might alter the appearance of logs completely written in RTL languages. However, this change is justified, considering the limitations in Xcode's editor regarding RTL language support, especially when RTL strings are combined with String Interpolation. As a result, string literals, particularly for logging purposes like network logs, are predominantly written in English.

Furthermore, considering network logging specifically, many standards and protocols are inherently in English, including standard headers and their values. This consideration supports the decision to enforce a left-to-right base writing direction for improved readability and consistency in such contexts.

Before the Fix After the Fix
Simulator Screenshot - iPhone 15 - 2024-01-23 at 21 42 12 Simulator Screenshot - iPhone 15 - 2024-01-23 at 22 01 17

Fix text writing direction to handle RTL languages.
@Mr-Alirezaa Mr-Alirezaa force-pushed the fix-writing-direction-rtl-langs branch from df79bdc to 5e6880c Compare January 23, 2024 18:36
@Mr-Alirezaa Mr-Alirezaa changed the title fix: Fix text writing direction to handle RTL languages (#114) fix: Text writing direction to handle RTL languages (#114) Jan 23, 2024
@kean
Copy link
Owner

kean commented Feb 1, 2024

Awesome, thank you for your contribution @Mr-Alirezaa!

@kean kean merged commit e4fc7cc into kean:main Feb 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants