Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display custom headers in the list view #196

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

tahirmt
Copy link
Contributor

@tahirmt tahirmt commented Jun 4, 2023

Adding an option to customize the list on iOS to be able to show any header value through the Settings page.

  • The headers that should be displayed in the list can be added easily from the Settings page
  • Can delete any watched header key by swiping

This is a replacement of #174

Screenshots

List view

Simulator Screenshot - iPhone 14 Pro - 2023-06-04 at 13 41 12

Settings

Simulator Screenshot - iPhone 14 Pro - 2023-06-04 at 13 41 44
Simulator Screenshot - iPhone 14 Pro - 2023-06-04 at 13 41 53

@tahirmt
Copy link
Contributor Author

tahirmt commented Jun 4, 2023

@kean What do you think about this implementation. It's more controlled. I would like there to be a way to add default values so that if someone wants to add some headers for their app they can start with that value instead of having to do it after launching the app.

@kean
Copy link
Owner

kean commented Jun 4, 2023

Thanks @tahirmt, this looks great!

instead of having to do it after launching the app.

Yes, there needs to be a way to configure it programmatically. I was considering making UserDefaults public in Pulse 4, so that you could do the following on the first app launch:

if isFirstAppRun {
    UserSettings.shared.displayHeaders = ["Cache-Control"]
}

I would also appreciate if you could target the pulse-4 branch instead of main. I wasn't planning to push any new 3.x releases.

@tahirmt tahirmt changed the base branch from main to pulse-4 June 4, 2023 18:45
@tahirmt
Copy link
Contributor Author

tahirmt commented Jun 4, 2023

@kean rebased to pulse-4 branch and changed the PR target.
That sounds good. If you make it public that will work!

@kean kean changed the base branch from pulse-4 to main June 6, 2023 02:00
@kean kean merged commit 09723a0 into kean:main Jun 6, 2023
7 of 9 checks passed
@tahirmt tahirmt deleted the add-header-to-main branch June 6, 2023 21:28
@tahirmt
Copy link
Contributor Author

tahirmt commented Jul 1, 2023

@kean I have a request for this to be a configurable option inside of Pulse for Mac. To be able to add headers to the list as a column or in the list view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants