Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TaskMessageBuilder to change what is shown in the list #174

Closed
wants to merge 2 commits into from

Conversation

tahirmt
Copy link
Contributor

@tahirmt tahirmt commented Mar 11, 2023

  • Introduce a way to customize the look of the list.
  • TaskMessageBuilder is a protocol that takes a NetworkTaskEntity and returns a view.
  • The default implementation is unchanged where it displays a Text with the url only
  • This can be used to customize what else gets displayed since the entire task is available.

@kean
Copy link
Owner

kean commented Mar 12, 2023

Hey, @tahirmt. Thanks for kicking this off. I was planning to add customization options for the list. My initial plan was to add a few customization options that you could either set using UserDefaults (programmatically) or via the Settings screen.

@tahirmt
Copy link
Contributor Author

tahirmt commented Mar 12, 2023

@kean my use case for this so far is that I want to show values for certain headers in the main list. For example if you've used Apollo GraphQL iOS it adds some headers that can let you identify operation name etc so having that on the list is super helpful.

@theo-brlle
Copy link

Hey @kean, I'm also interested in a feature to customize the rows in the list in order to easily detect GraphQL queries / mutations. Do you consider merging this PR for 4.0.0? 🤔
Thanks in advance! 🙏

@kean
Copy link
Owner

kean commented Jun 3, 2023

Hey, @theo-brlle. I'm not entirely sure because allowing the users to completely replace the cells is probably not something I would want to expose in the public API.

In Pulse for Mac, there is going to be an option to add table columns displaying any of the predefined HTTP header values. It may be worth adding something like that to the list as well.

@tahirmt
Copy link
Contributor Author

tahirmt commented Jun 6, 2023

This is no longer necessary with support to show headers in the list. #196

@tahirmt tahirmt closed this Jun 6, 2023
@tahirmt tahirmt deleted the custom-look branch June 6, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants