Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged isodate & pydantic libraries into lambda directory; modified requirements.txt, lambda_function.py; added en-CA.json file #246

Closed
wants to merge 32 commits into from

Conversation

danielbrunt57
Copy link

Merged the 4 files/folders which previously had to be added from the master version's ZIP file so that step is not required:

  • typing_extensions.py
  • __pycache__/
  • isodate/
  • pydantic/

Modified requirements.txt file:

ask_sdk_core
isodate~=0.6.0
pydantic~=1.10.4
typing-extensions~=4.10.0
urllib3==1.26.1

Modified lambda_function.py file:

""" NO NEED TO EDIT ANYTHING UNDER THE LINE """
# Built-In Imports
import ask_sdk_core
import ask_sdk_model
import json
import urllib3
from ask_sdk_core.dispatch_components import AbstractExceptionHandler
from ask_sdk_core.dispatch_components import AbstractRequestHandler
from ask_sdk_core.dispatch_components import AbstractRequestInterceptor
from ask_sdk_core.skill_builder import SkillBuilder
from ask_sdk_core.utils import (
    get_account_linking_access_token,
    is_request_type,
    is_intent_name,
    get_intent_name,
    get_slot,
    get_slot_value,
)
from ask_sdk_model import SessionEndedReason
from ask_sdk_model.slu.entityresolution import StatusCode
from typing import Union, Optional
from urllib3 import HTTPResponse

# Local Imports
import isodate
import prompts
from schemas import HaState, HaStateError
from utils import get_logger
from const import (
    INPUT_TEXT_ENTITY,
    RESPONSE_YES,
    RESPONSE_NO,
    RESPONSE_NONE,
    RESPONSE_SELECT,
    RESPONSE_NUMERIC,
    RESPONSE_DURATION,
    RESPONSE_STRING,
    RESPONSE_DATE_TIME,
)

Created en-CA.json interaction model so I can use my Echo devices in my account's native language setting!

@lorenzomartini1
Copy link

you solved my anxiety-problem of the day! 🥇

@DEADSEC-SECURITY
Copy link
Collaborator

Not allowing this PR. We cannot have packages directly in the repo. The releases automatically generate the zip files with all required stuff so please use that. Regarding the en-CA.json and other modifications feel free to open a PR for each on. A Pull request should only fix one single thing at the time or add one single feature. This makes it easier to backtrack bugs and analyze PRS.

@danielbrunt57
Copy link
Author

Will do, and thanks for returning to action!
I had resolved my issue the only way I knew how but look forward to working with yours moving forward. And yes, AWS's constant changes do suck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants