Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for GCP custom timeHorizon field #1387

Merged
merged 3 commits into from
May 4, 2024

Conversation

Yaxhveer
Copy link
Contributor

@Yaxhveer Yaxhveer commented May 3, 2024

Docs: kedacore/keda#5778

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@Yaxhveer Yaxhveer requested a review from a team as a code owner May 3, 2024 20:18
Copy link

github-actions bot commented May 3, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented May 3, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 1efa8d0
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6636790079e6750008a4a33a
😎 Deploy Preview https://deploy-preview-1387--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the other scalers as well 🙏

Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks ❤️

@JorTurFer JorTurFer merged commit 0979a14 into kedacore:main May 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants