Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New arbitrary arguments + minor fixes #165

Merged
merged 13 commits into from
Nov 29, 2022
Merged

Conversation

gauron99
Copy link
Contributor

  • add new fields for arbitrary arguments
  • fix makefile bundle building & deployment with make deploy-olm
  • update RELEASE-PROCESS notes for newer version

@gauron99 gauron99 marked this pull request as draft November 27, 2022 20:00
README.md Outdated Show resolved Hide resolved
RELEASE-PROCESS.MD Outdated Show resolved Hide resolved
@gauron99 gauron99 marked this pull request as ready for review November 28, 2022 13:43
@gauron99 gauron99 force-pushed the arbitrary-args branch 2 times, most recently from 0e8c091 to b7df9d8 Compare November 28, 2022 15:30
Makefile Outdated Show resolved Hide resolved
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
…ct current state of Makefile in case of testing and not using ghcr.io/kedacore images

Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
@github-actions
Copy link

Diff 2.8.1/manifests/keda.sh_triggerauthentications.yaml & 2.7.1/manifests/keda.sh_triggerauthentications.yaml

5c5
<     controller-gen.kubebuilder.io/version: v0.8.0
---
>     controller-gen.kubebuilder.io/version: v0.9.0
9c9
<     app.kubernetes.io/version: 2.7.1
---
>     app.kubernetes.io/version: 2.8.1
42c42,44
<             description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
---
>             description: 'APIVersion defines the versioned schema of this representation
>               of an object. Servers should convert recognized schemas to the latest
>               internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
45c47,49
<             description: 'Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
---
>             description: 'Kind is a string value representing the REST resource this
>               object represents. Servers may infer this from the endpoint the client
>               submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
53c57,58
<                 description: AzureKeyVault is used to authenticate using Azure Key Vault
---
>                 description: AzureKeyVault is used to authenticate using Azure Key
>                   Vault
114d118
<                 - credentials
120c124,125
<                   description: AuthEnvironment is used to authenticate using environment variables in the destination ScaleTarget spec
---
>                   description: AuthEnvironment is used to authenticate using environment
>                     variables in the destination ScaleTarget spec
134c139,140
<                 description: HashiCorpVault is used to authenticate using Hashicorp Vault
---
>                 description: HashiCorpVault is used to authenticate using Hashicorp
>                   Vault
139c145,146
<                     description: VaultAuthentication contains the list of Hashicorp Vault authentication methods
---
>                     description: VaultAuthentication contains the list of Hashicorp
>                       Vault authentication methods
142c149,150
<                     description: Credential defines the Hashicorp Vault credentials depending on the authentication method
---
>                     description: Credential defines the Hashicorp Vault credentials
>                       depending on the authentication method
157c165,166
<                       description: VaultSecret defines the mapping between the path of the secret in Vault to the parameter
---
>                       description: VaultSecret defines the mapping between the path
>                         of the secret in Vault to the parameter
177c186,187
<                 description: AuthPodIdentity allows users to select the platform native identity mechanism
---
>                 description: AuthPodIdentity allows users to select the platform native
>                   identity mechanism
178a189,190
>                   identityId:
>                     type: string
187c199,200
<                   description: AuthSecretTargetRef is used to authenticate using a reference to a secret
---
>                   description: AuthSecretTargetRef is used to authenticate using a
>                     reference to a secret
208,213d220
< status:
<   acceptedNames:
<     kind: ""
<     plural: ""
<   conditions: []
<   storedVersions: []

@github-actions
Copy link

Diff 2.8.1/manifests/keda.v2.8.1.clusterserviceversion.yaml & 2.7.1/manifests/keda.v2.7.1.clusterserviceversion.yaml

114,115c114,115
<     containerImage: ghcr.io/kedacore/keda-olm-operator:2.7.1
<     createdAt: "2022-05-11T00:00:00.000Z"
---
>     containerImage: ghcr.io/kedacore/keda-olm-operator:2.8.1
>     createdAt: "2022-09-15T00:00:00.000Z"
118c118
<     operators.operatorframework.io/builder: operator-sdk-v1.16.0
---
>     operators.operatorframework.io/builder: operator-sdk-v1.23.0
122c122
<   name: keda.v2.7.1
---
>   name: keda.v2.8.1
533c533
<                 image: ghcr.io/kedacore/keda-olm-operator:2.7.1
---
>                 image: ghcr.io/kedacore/keda-olm-operator:2.8.1
592c592
<   replaces: keda.v2.6.1
---
>   replaces: keda.v2.7.1
594c594
<   version: 2.7.1
---
>   version: 2.8.1

@github-actions
Copy link

Diff 2.8.1/metadata/annotations.yaml & 2.7.1/metadata/annotations.yaml

8c8
<   operators.operatorframework.io.metrics.builder: operator-sdk-v1.3.0
---
>   operators.operatorframework.io.metrics.builder: operator-sdk-v1.23.0

@github-actions
Copy link

Diff 2.8.1/manifests/keda.sh_kedacontrollers.yaml & 2.7.1/manifests/keda.sh_kedacontrollers.yaml

5c5
<     controller-gen.kubebuilder.io/version: v0.4.1
---
>     controller-gen.kubebuilder.io/version: v0.9.0
1763a1764,1769
>                   args:
>                     description: 'Allow users to define any argument with possibility
>                       to override already existing or previously defined arguments.'
>                     items:
>                       type: string
>                     type: array
2746a2753,2758
>                   args:
>                     description: 'Allow users to define any argument with possibility
>                       to override already existing or previously defined arguments.'
>                     items:
>                       type: string
>                     type: array

@github-actions
Copy link

Diff output of 2.8.1/manifests/keda.sh_scaledjobs.yaml is too large - character limit 65536 exceeded for github comment

@github-actions
Copy link

Diff 2.8.1/manifests/keda.sh_clustertriggerauthentications.yaml & 2.7.1/manifests/keda.sh_clustertriggerauthentications.yaml

5c5
<     controller-gen.kubebuilder.io/version: v0.8.0
---
>     controller-gen.kubebuilder.io/version: v0.9.0
9c9
<     app.kubernetes.io/version: 2.7.1
---
>     app.kubernetes.io/version: 2.8.1
39c39,40
<         description: ClusterTriggerAuthentication defines how a trigger can authenticate globally
---
>         description: ClusterTriggerAuthentication defines how a trigger can authenticate
>           globally
42c43,45
<             description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
---
>             description: 'APIVersion defines the versioned schema of this representation
>               of an object. Servers should convert recognized schemas to the latest
>               internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
45c48,50
<             description: 'Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
---
>             description: 'Kind is a string value representing the REST resource this
>               object represents. Servers may infer this from the endpoint the client
>               submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
53c58,59
<                 description: AzureKeyVault is used to authenticate using Azure Key Vault
---
>                 description: AzureKeyVault is used to authenticate using Azure Key
>                   Vault
114d119
<                 - credentials
120c125,126
<                   description: AuthEnvironment is used to authenticate using environment variables in the destination ScaleTarget spec
---
>                   description: AuthEnvironment is used to authenticate using environment
>                     variables in the destination ScaleTarget spec
134c140,141
<                 description: HashiCorpVault is used to authenticate using Hashicorp Vault
---
>                 description: HashiCorpVault is used to authenticate using Hashicorp
>                   Vault
139c146,147
<                     description: VaultAuthentication contains the list of Hashicorp Vault authentication methods
---
>                     description: VaultAuthentication contains the list of Hashicorp
>                       Vault authentication methods
142c150,151
<                     description: Credential defines the Hashicorp Vault credentials depending on the authentication method
---
>                     description: Credential defines the Hashicorp Vault credentials
>                       depending on the authentication method
157c166,167
<                       description: VaultSecret defines the mapping between the path of the secret in Vault to the parameter
---
>                       description: VaultSecret defines the mapping between the path
>                         of the secret in Vault to the parameter
177c187,188
<                 description: AuthPodIdentity allows users to select the platform native identity mechanism
---
>                 description: AuthPodIdentity allows users to select the platform native
>                   identity mechanism
178a190,191
>                   identityId:
>                     type: string
187c200,201
<                   description: AuthSecretTargetRef is used to authenticate using a reference to a secret
---
>                   description: AuthSecretTargetRef is used to authenticate using a
>                     reference to a secret
208,213d221
< status:
<   acceptedNames:
<     kind: ""
<     plural: ""
<   conditions: []
<   storedVersions: []

@github-actions
Copy link

Diff 2.8.1/manifests/keda.sh_scaledobjects.yaml & 2.7.1/manifests/keda.sh_scaledobjects.yaml

5c5
<     controller-gen.kubebuilder.io/version: v0.8.0
---
>     controller-gen.kubebuilder.io/version: v0.9.0
9c9
<     app.kubernetes.io/version: 2.7.1
---
>     app.kubernetes.io/version: 2.8.1
59c59,61
<             description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
---
>             description: 'APIVersion defines the versioned schema of this representation
>               of an object. Servers should convert recognized schemas to the latest
>               internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
62c64,66
<             description: 'Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
---
>             description: 'Kind is a string value representing the REST resource this
>               object represents. Servers may infer this from the endpoint the client
>               submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
73c77,78
<                     description: HorizontalPodAutoscalerConfig specifies horizontal scale config
---
>                     description: HorizontalPodAutoscalerConfig specifies horizontal
>                       scale config
76c81,83
<                         description: HorizontalPodAutoscalerBehavior configures the scaling behavior of the target in both Up and Down directions (scaleUp and scaleDown fields respectively).
---
>                         description: HorizontalPodAutoscalerBehavior configures the
>                           scaling behavior of the target in both Up and Down directions
>                           (scaleUp and scaleDown fields respectively).
79c86,90
<                             description: scaleDown is scaling policy for scaling Down. If not set, the default value is to allow to scale down to minReplicas pods, with a 300 second stabilization window (i.e., the highest recommendation for the last 300sec is used).
---
>                             description: scaleDown is scaling policy for scaling Down.
>                               If not set, the default value is to allow to scale down
>                               to minReplicas pods, with a 300 second stabilization
>                               window (i.e., the highest recommendation for the last
>                               300sec is used).
82c93,96
<                                 description: policies is a list of potential scaling polices which can be used during scaling. At least one policy must be specified, otherwise the HPAScalingRules will be discarded as invalid
---
>                                 description: policies is a list of potential scaling
>                                   polices which can be used during scaling. At least
>                                   one policy must be specified, otherwise the HPAScalingRules
>                                   will be discarded as invalid
84c98,99
<                                   description: HPAScalingPolicy is a single policy which must hold true for a specified past interval.
---
>                                   description: HPAScalingPolicy is a single policy
>                                     which must hold true for a specified past interval.
87c102,105
<                                       description: PeriodSeconds specifies the window of time for which the policy should hold true. PeriodSeconds must be greater than zero and less than or equal to 1800 (30 min).
---
>                                       description: PeriodSeconds specifies the window
>                                         of time for which the policy should hold true.
>                                         PeriodSeconds must be greater than zero and
>                                         less than or equal to 1800 (30 min).
91c109,110
<                                       description: Type is used to specify the scaling policy.
---
>                                       description: Type is used to specify the scaling
>                                         policy.
94c113,115
<                                       description: Value contains the amount of change which is permitted by the policy. It must be greater than zero
---
>                                       description: Value contains the amount of change
>                                         which is permitted by the policy. It must
>                                         be greater than zero
104c125,127
<                                 description: selectPolicy is used to specify which policy should be used. If not set, the default value MaxPolicySelect is used.
---
>                                 description: selectPolicy is used to specify which
>                                   policy should be used. If not set, the default value
>                                   MaxPolicySelect is used.
107c130,138
<                                 description: 'StabilizationWindowSeconds is the number of seconds for which past recommendations should be considered while scaling up or scaling down. StabilizationWindowSeconds must be greater than or equal to zero and less than or equal to 3600 (one hour). If not set, use the default values: - For scale up: 0 (i.e. no stabilization is done). - For scale down: 300 (i.e. the stabilization window is 300 seconds long).'
---
>                                 description: 'StabilizationWindowSeconds is the number
>                                   of seconds for which past recommendations should
>                                   be considered while scaling up or scaling down.
>                                   StabilizationWindowSeconds must be greater than
>                                   or equal to zero and less than or equal to 3600
>                                   (one hour). If not set, use the default values:
>                                   - For scale up: 0 (i.e. no stabilization is done).
>                                   - For scale down: 300 (i.e. the stabilization window
>                                   is 300 seconds long).'
112c143,146
<                             description: 'scaleUp is scaling policy for scaling Up. If not set, the default value is the higher of: * increase no more than 4 pods per 60 seconds * double the number of pods per 60 seconds No stabilization is used.'
---
>                             description: 'scaleUp is scaling policy for scaling Up.
>                               If not set, the default value is the higher of: * increase
>                               no more than 4 pods per 60 seconds * double the number
>                               of pods per 60 seconds No stabilization is used.'
115c149,152
<                                 description: policies is a list of potential scaling polices which can be used during scaling. At least one policy must be specified, otherwise the HPAScalingRules will be discarded as invalid
---
>                                 description: policies is a list of potential scaling
>                                   polices which can be used during scaling. At least
>                                   one policy must be specified, otherwise the HPAScalingRules
>                                   will be discarded as invalid
117c154,155
<                                   description: HPAScalingPolicy is a single policy which must hold true for a specified past interval.
---
>                                   description: HPAScalingPolicy is a single policy
>                                     which must hold true for a specified past interval.
120c158,161
<                                       description: PeriodSeconds specifies the window of time for which the policy should hold true. PeriodSeconds must be greater than zero and less than or equal to 1800 (30 min).
---
>                                       description: PeriodSeconds specifies the window
>                                         of time for which the policy should hold true.
>                                         PeriodSeconds must be greater than zero and
>                                         less than or equal to 1800 (30 min).
124c165,166
<                                       description: Type is used to specify the scaling policy.
---
>                                       description: Type is used to specify the scaling
>                                         policy.
127c169,171
<                                       description: Value contains the amount of change which is permitted by the policy. It must be greater than zero
---
>                                       description: Value contains the amount of change
>                                         which is permitted by the policy. It must
>                                         be greater than zero
137c181,183
<                                 description: selectPolicy is used to specify which policy should be used. If not set, the default value MaxPolicySelect is used.
---
>                                 description: selectPolicy is used to specify which
>                                   policy should be used. If not set, the default value
>                                   MaxPolicySelect is used.
140c186,194
<                                 description: 'StabilizationWindowSeconds is the number of seconds for which past recommendations should be considered while scaling up or scaling down. StabilizationWindowSeconds must be greater than or equal to zero and less than or equal to 3600 (one hour). If not set, use the default values: - For scale up: 0 (i.e. no stabilization is done). - For scale down: 300 (i.e. the stabilization window is 300 seconds long).'
---
>                                 description: 'StabilizationWindowSeconds is the number
>                                   of seconds for which past recommendations should
>                                   be considered while scaling up or scaling down.
>                                   StabilizationWindowSeconds must be greater than
>                                   or equal to zero and less than or equal to 3600
>                                   (one hour). If not set, use the default values:
>                                   - For scale up: 0 (i.e. no stabilization is done).
>                                   - For scale down: 300 (i.e. the stabilization window
>                                   is 300 seconds long).'
144a199,200
>                       name:
>                         type: string
178c234,235
<                 description: ScaleTarget holds the a reference to the scale target Object
---
>                 description: ScaleTarget holds the a reference to the scale target
>                   Object
196c253,255
<                       description: ScaledObjectAuthRef points to the TriggerAuthentication or ClusterTriggerAuthentication object that is used to authenticate the scaler with the environment
---
>                       description: ScaledObjectAuthRef points to the TriggerAuthentication
>                         or ClusterTriggerAuthentication object that is used to authenticate
>                         the scaler with the environment
199c258,259
<                           description: Kind of the resource being referred to. Defaults to TriggerAuthentication.
---
>                           description: Kind of the resource being referred to. Defaults
>                             to TriggerAuthentication.
211c271,273
<                       description: MetricTargetType specifies the type of metric being targeted, and should be either "Value", "AverageValue", or "Utilization"
---
>                       description: MetricTargetType specifies the type of metric being
>                         targeted, and should be either "Value", "AverageValue", or
>                         "Utilization"
230c292,293
<                 description: Conditions an array representation to store multiple Conditions
---
>                 description: Conditions an array representation to store multiple
>                   Conditions
235c298,299
<                       description: A human readable message indicating details about the transition.
---
>                       description: A human readable message indicating details about
>                         the transition.
263c327,328
<                       description: HealthStatusType is an indication of whether the health status is happy or failing
---
>                       description: HealthStatusType is an indication of whether the
>                         health status is happy or failing
266a332,333
>               hpaName:
>                 type: string
281c348,349
<                 description: GroupVersionKindResource provides unified structure for schema.GroupVersionKind and Resource
---
>                 description: GroupVersionKindResource provides unified structure for
>                   schema.GroupVersionKind and Resource
307,312d374
< status:
<   acceptedNames:
<     kind: ""
<     plural: ""
<   conditions: []
<   storedVersions: []

@zroubalik zroubalik merged commit e02926d into kedacore:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants