Service bus queue #101
Service bus queue #101
Conversation
lee0c
force-pushed
the
service_bus_queue
branch
from
7f60840
to
c0aff5d
Compare
|
I believe TargetAverageValue is correct here- the idea being we try to estimate the number of messages a function pod can process- in the PAAS offering for functions for example it is 1000 messages per worker before we scale and add another worker. |
|
@Aarthisk you're entirely right, I was reading that wrong the other day. Let me revert that change |
…d variable" This reverts commit c2f1a4e.
pkg/handler/scale_handler.go
Outdated
| @@ -467,6 +469,8 @@ func (h *ScaleHandler) getScaler(trigger kore_v1alpha1.ScaleTriggers, resolvedEn | |||
| switch trigger.Type { | |||
| case "azure-queue": | |||
| return scalers.NewAzureQueueScaler(resolvedEnv, trigger.Metadata) | |||
| case "serviceBusTrigger": // TODO in func core tools probably: define type for this | |||
There was a problem hiding this comment.
I'd rather this be azure-servicebus to be consistent with other triggers here. I think rabbitMQ should be rabbitmq as well, but that can go in a separate PR.
I don't understand the TODO though. The core-tools will have its own mapping of azure functions trigger name <=> keda trigger name.
| Azure Functions trigger name | Keda trigger name |
|---|---|
queueTrigger |
azure-queue |
blobTrigger |
azure-blob |
serviceBusTrigger |
azure-servicebus |
kafkaTrigger |
kafka |
httpTrigger |
N/A |
There was a problem hiding this comment.
theTODO was in relation to making sure this got cleaned up on the core tools side - right now it still goes through as serviceBusTrigger afaik. If core tools is updated I can switch this to azure-servicebus - though will SB Queues & SB Topics/Subscriptions have different triggers?
There was a problem hiding this comment.
@ahmelsayed poking through func cli looks like Queues & Topics have the same trigger name but different metadata - I think @priyaananthasankar & I will be looking at implementing Topics scaler later so we can sort out how to differentiate between the two then.
Regardless, will push the change for serviceBusTrigger -> azure-servicebus
Service bus queue Former-commit-id: aa61d2b
Service bus queue Former-commit-id: 1275c68
Implements #15
Additionally:
switches scalers from TargetAverageValue to TargetValue metrics (Avg value is for averages across pods & doesn't make sense for a message queue)Read docs wrong, this is reverted