Eventhub podidentity #1305
Merged
Eventhub podidentity #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emad Alashi <emad.ashi@gmail.com>
Signed-off-by: Emad Alashi <emad.ashi@gmail.com>
zroubalik
reviewed
Nov 1, 2020
Signed-off-by: Emad Alashi <emad.ashi@gmail.com>
Signed-off-by: Emad Alashi <emad.ashi@gmail.com>
Signed-off-by: Emad Alashi <emad.ashi@gmail.com>
Signed-off-by: Emad Alashi <emad.ashi@gmail.com>
|
Looking good, bug I keep the proper review for someone Azure related. Let's hold merging this PR open for a while, once we are clear that the next release will be 2.1 and not 2.0.1 or something similar. |
|
@eashi I am very sorry, we have changed the Changelog a little bit, could you please update your PR and add this feature to the |
No problem, done. |
ahmelsayed
approved these changes
Nov 16, 2020
1 task
arschles
pushed a commit
to arschles/keda
that referenced
this pull request
Dec 1, 2020
Signed-off-by: Emad Alashi <emad.ashi@gmail.com> Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
arschles
pushed a commit
to arschles/keda
that referenced
this pull request
Dec 1, 2020
Signed-off-by: Emad Alashi <emad.ashi@gmail.com> Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
arschles
pushed a commit
to arschles/keda
that referenced
this pull request
Dec 1, 2020
Signed-off-by: Emad Alashi <emad.ashi@gmail.com> Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Pod Identity for Event Hub. Users will be able to use Pod Identity instead of depending on supplying a connection string. But this also means that they have to supply EventHubNamespace and EventHubName explicitly.
Checklist