Add ratelimitting parameters to keda manager #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
JorTurFer
reviewed
Oct 8, 2022
|
/run-e2e internal* |
vflaux
force-pushed
the
flag_qps_burst
branch
2 times, most recently
from
7babe1d
to
8e2a242
Compare
JorTurFer
reviewed
Oct 10, 2022
JorTurFer
reviewed
Oct 10, 2022
zroubalik
reviewed
Oct 10, 2022
There was a problem hiding this comment.
Could you please also update documentation to reflect this feature?
https://keda.sh/docs/2.8/operate/cluster/#kubernetes-client-parameters
he did it kedacore/keda-docs#953 |
vflaux
force-pushed
the
flag_qps_burst
branch
from
8e2a242
to
d179d4e
Compare
…ent defaults Signed-off-by: Valentin Flaux <valentin_flaux@connect-tech.sncf>
vflaux
force-pushed
the
flag_qps_burst
branch
from
d179d4e
to
c9a056c
Compare
|
/run-e2e internal* |
JorTurFer
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding flags to the manager main so that we can override the default client QPS and burst. This allows us to enable higher throughput of reconciliations when there is a lot of ScaledObjects in the cluster.
Regarding the helm chart: the flags can be added with
extraArgs.kedain values.Checklist
Fixes #3730