AWS SQS: Respect scaleOnDelayed #4383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ding <ivan.ding@grabtaxi.com>
Signed-off-by: Ivan Ding <ivan.ding@grabtaxi.com>
Signed-off-by: Ivan Ding <ivan.ding@grabtaxi.com>
Signed-off-by: Ivan Ding <ivan.ding@grabtaxi.com>
Signed-off-by: Ivan Ding <ivan.ding@grabtaxi.com>
Signed-off-by: Ivan Ding <ivan.ding@grabtaxi.com>
Signed-off-by: Ivan Ding <ivan.ding@grabtaxi.com>
JorTurFer
reviewed
Mar 20, 2023
| @@ -53,6 +53,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio | |||
|
|
|||
| ### Fixes | |||
|
|
|||
| - **AWS SQS Scaler**: Respect `scaleOnDelayed` value ([#4377](https://github.com/kedacore/keda/issue/4377)) | |||
There was a problem hiding this comment.
Could you move this to New section? This isn't a fix because it's a new feature. The message should be something like Add support to scaledOnDelayed
Comment on lines
-27
to
29
| "ApproximateNumberOfMessages", | ||
| "ApproximateNumberOfMessagesNotVisible", | ||
| } | ||
|
|
||
| var awsSqsQueueMetricNamesForNotScalingInFlight = []string{ | ||
| var awsSqsQueueMetricNamesForScaling = []string{ | ||
| "ApproximateNumberOfMessages", | ||
| } |
There was a problem hiding this comment.
Does keeping this here make sense? I mean, maybe we could just move it to the parsing function
|
@ding1992 any update on this please? |
|
I'm very interested in this functionality. @ding1992 any updates at all? Anything I can help with? |
|
@JorTurFer Yes, I'll give it a go! |
7 tasks
|
I linked to this PR in my new PR, but just for clarity, here is the new PR #4900 |
|
already done by #4900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes #4377