Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS sqs scaler to support scaleOnDelayed #4377

Closed
ding1992 opened this issue Mar 15, 2023 · 7 comments · Fixed by #4900
Closed

AWS sqs scaler to support scaleOnDelayed #4377

ding1992 opened this issue Mar 15, 2023 · 7 comments · Fixed by #4900
Labels
stale All issues that are marked as stale due to inactivity

Comments

@ding1992
Copy link

Proposal
Similar to scaleOnInFlight, it'd be appreciated if we could have scaleOnDelayed to indicate whether messageDelayed metric should be counted in to a trigger check.

Use Case
Our service consumes messages from SQS, queue them internally and deletes them from SQS immediately (we can't change this at the moment).
Hence it's possible that scale down would happen while the service is still processing the messages, because SQS is already empty.
We could set a longer cooldownPeriod (e.g. 30mins), but it's still possible that our service could consume and delete new messages between two polling checks (hence 30mins cool down is not refreshed).

If scaleOnDelayed is available, we could set delaySeconds = 10s when we add messages to the queue, and pollingInterval=5s.
This way 30mins cool down would always be refreshed when there is a new message.

Is this a feature you are interested in implementing yourself?
Maybe

Anything else?
No

@JorTurFer
Copy link
Member

Hey @ding1992
I think that this could be a good addition if the SDK supports it.
Are you willing to contribute with the feature?
You would have to add the new parameter and the parsing in this file and covering with tests in this other file (and of course update the docs with the new parameter :) )

@ding1992
Copy link
Author

ding1992 commented Mar 16, 2023

#4383

@JorTurFer
Copy link
Member

I'll check it tomorrow

@stale
Copy link

stale bot commented May 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label May 15, 2023
@stale
Copy link

stale bot commented May 23, 2023

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed May 23, 2023
@zroubalik zroubalik reopened this May 23, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label May 23, 2023
@stale
Copy link

stale bot commented Jul 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jul 22, 2023
@stale
Copy link

stale bot commented Jul 29, 2023

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Jul 29, 2023
phr3nzii added a commit to phr3nzii/keda that referenced this issue Aug 23, 2023
phr3nzii added a commit to phr3nzii/keda that referenced this issue Aug 23, 2023
phr3nzii added a commit to phr3nzii/keda that referenced this issue Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale All issues that are marked as stale due to inactivity
Projects
Status: Ready To Ship
3 participants