Pulsar Scaler: fix msgBacklogThreshold field being named wrongly as msgBacklog
#4736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
JorTurFer
reviewed
Jun 29, 2023
|
Thanks for the PR, I have left some small nits |
|
/run-e2e pulsar |
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
dttung2905
force-pushed
the
fix-pulsar-scaler-msgbacklog
branch
from
80453c0
to
6c3a227
Compare
JorTurFer
reviewed
Jun 29, 2023
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
|
Ah ha, no wonder I have a feeling that I was missing something 😆 |
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
|
/run-e2e pulsar |
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Jul 27, 2023
… `msgBacklog` (kedacore#4736) Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Jul 27, 2023
… `msgBacklog` (kedacore#4736) Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Jul 27, 2023
… `msgBacklog` (kedacore#4736) Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
JorTurFer
added a commit
that referenced
this pull request
Jul 27, 2023
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg> Co-authored-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com> fix `msgBacklogThreshold` field being named wrongly as `msgBacklog` (#4736) fix: AWS Pod Identity uses default service account if not provided (#4768) fix: Restore prometheus metrics in Metrics Server (#4766) fix repo bug (#4792)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR aims to ix
msgBacklogThresholdfield being named wrongly asmsgBacklog. I pass down the logger into the methodparsePulsarMetadataas wellChecklist
Fixes #4681