Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restore prometheus metrics in Metrics Server #4766

Merged
merged 5 commits into from
Jul 7, 2023
Merged

fix: Restore prometheus metrics in Metrics Server #4766

merged 5 commits into from
Jul 7, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jul 3, 2023 •
edited

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4776

@JorTurFer
fix: Restore prometheus metrics in Metrics Server
fd54946 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@JorTurFer
remove not used code
8582eae 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 3, 2023 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer removed the skip-e2e label Jul 4, 2023
@JorTurFer JorTurFer mentioned this pull request Jul 5, 2023
Closed
JorTurFer and others added 3 commits July 5, 2023 15:43
@JorTurFer
update chagnelog
44253ac 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
add e2e test
45b80f6 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Merge branch 'main' into fix-prometheus
b520381 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer JorTurFer marked this pull request as ready for review July 5, 2023 15:57
@JorTurFer JorTurFer requested a review from a team as a code owner July 5, 2023 15:57
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 5, 2023 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

zroubalik
zroubalik approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit b4919ea into kedacore:main Jul 7, 2023
21 checks passed
@JorTurFer JorTurFer deleted the fix-prometheus branch July 7, 2023 10:47
@rajatvig
Copy link

rajatvig commented Jul 7, 2023

Could we do a 2.11.2 release with this? We are blocked on the upgrade for this

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 7, 2023 •
edited

Could we do a 2.11.2 release with this? We are blocked on the upgrade for this

Yes, we plan to cut a release soon (next week or 2 weeks max) with this and other fixes, but just to clarify, this PR doesn't restore all the metrics (including the deprecated metrics), this PR restores the expected metrics for v2.11 (operator-sdk metrics)

Are you using keda_metrics_adapter* metrics? If yes, those metrics won't be restored as they were deprecated and removed based on our deprecation policy. If that's your case, you have to migrate to the new metrics (scrapped from the operator pod)

@rajatvig
Copy link

rajatvig commented Jul 7, 2023

Could we do a 2.11.2 release with this? We are blocked on the upgrade for this

Yes, we plan to cut a release soon (next week or 2 weeks max) with this and other fixes, but just to clarify, this PR doesn't restore all the metrics (including the deprecated metrics), this PR restores the expected metrics for v2.11 (operator-sdk metrics)

Are you using keda_metrics_adapter* metrics? If yes, those metrics won't be restored as they were deprecated and removed based on our deprecation policy. If that's your case, you have to migrate to the new metrics (scrapped from the operator pod)

The blocker is the alert for the target down for the metrics server on the upgrade. Migrating the alerts to use the new metrics vs the old ones is work we already done.

@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 7, 2023 •
edited

The blocker is the alert for the target down for the metrics server on the upgrade. Migrating the alerts to use the new metrics vs the old ones is work we already done.

Nice! then the fill will be available soon 😄

JorTurFer added a commit to JorTurFer/keda that referenced this pull request Jul 27, 2023
@JorTurFer
fix: Restore prometheus metrics in Metrics Server (kedacore#4766)
ecea548 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Jul 27, 2023
@JorTurFer
fix: Restore prometheus metrics in Metrics Server (kedacore#4766)
1026146 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Jul 27, 2023
@JorTurFer
fix: Restore prometheus metrics in Metrics Server (kedacore#4766)
f71b895 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
JorTurFer added a commit that referenced this pull request Jul 27, 2023
@JorTurFer
chore: cherry pick commits for release v2.11.2 (#4826)
517ed30 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Co-authored-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com>
fix `msgBacklogThreshold` field being named wrongly as `msgBacklog` (#4736)
fix: AWS Pod Identity uses default service account if not provided (#4768)
fix: Restore prometheus metrics in Metrics Server (#4766)
fix repo bug (#4792)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to scrape metrics on the keda metrics server
4 participants
@JorTurFer @rajatvig @zroubalik @keda-automation