Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing side effects from the ScaledObject webhook when the request is in dry-run mode #5307

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix: removing side effects from the ScaledObject webhook when the request is in dry-run mode #5307

merged 1 commit into from
Dec 21, 2023

Conversation

rodrigorfk
Copy link
Contributor

@rodrigorfk rodrigorfk commented Dec 21, 2023 •
edited by zroubalik
Loading

The ScaledObject Admission Webhook validator was changed to a CustomValidor allowing removing side effects when the request is in dry-run mode.

Checklist

  • [N/A] When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [N/A] A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5306

@rodrigorfk
fix: removing side effects from the ScaledObject webhook when the req…
5ee2ceb 
…uest is in dry-run mode

Signed-off-by: Rodrigo Fior Kuntzer <rodrigo@miro.com>
@rodrigorfk rodrigorfk requested a review from a team as a code owner December 21, 2023 13:36
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@zroubalik
Copy link
Member

zroubalik commented Dec 21, 2023 •
edited by github-actions bot
Loading

/run-e2e scaled_object_validation
Update: You can check the progress here

zroubalik
zroubalik approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@zroubalik zroubalik enabled auto-merge (squash) December 21, 2023 14:19
@zroubalik zroubalik merged commit 4f2ea09 into kedacore:main Dec 21, 2023
20 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@rodrigorfk @toniiiik
fix: removing side effects from the ScaledObject webhook when the req…
6eeaf7c 
…uest is in dry-run mode (kedacore#5307)

Signed-off-by: Rodrigo Fior Kuntzer <rodrigo@miro.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
@rodrigorfk rodrigorfk deleted the fix-5306 branch January 19, 2024 10:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScaledObject Validating Webhook should support dry-run=server requests
2 participants
@rodrigorfk @zroubalik