Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prometheus-scaler): AWS signv4 parses region if provided #5421

Merged
merged 6 commits into from
Jan 20, 2024
Merged

fix(prometheus-scaler): AWS signv4 parses region if provided #5421

merged 6 commits into from
Jan 20, 2024

Conversation

sguruvar
Copy link
Contributor

@sguruvar sguruvar commented Jan 20, 2024 •
edited by JorTurFer

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5419

tomkerkhove and others added 3 commits January 20, 2024 12:40
@tomkerkhove @sguruvar
chore: Improve new features in v2.13.0 changelog (kedacore#5413)
09b3321 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
@sguruvar
Merge branch 'main' of https://github.com/sguruvar/keda
52c757a 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
@sguruvar
https://github.com/kedacore/keda/issues/5419
1c87939 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
@sguruvar sguruvar requested a review from a team as a code owner January 20, 2024 18:43
@JorTurFer
Copy link
Member

JorTurFer commented Jan 20, 2024 •
edited by github-actions bot

/run-e2e aws
Update: You can check the progress here

@sguruvar
https://github.com/kedacore/keda/issues/5419
9a2a86f 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
@JorTurFer JorTurFer changed the title Fix for bug https://github.com/kedacore/keda/issues/5419 fix: Prometheus Scaler parses AWS Region if provided Jan 20, 2024
@JorTurFer JorTurFer changed the title fix: Prometheus Scaler parses AWS Region if provided fix(prometheus-scaler): AWS signv4 parses region if provided Jan 20, 2024
JorTurFer
JorTurFer reviewed Jan 20, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scalers/aws/aws_sigv4.go Outdated Show resolved Hide resolved
@JorTurFer
Apply suggestions from code review
6485f67 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member

JorTurFer commented Jan 20, 2024 •
edited by github-actions bot

/run-e2e aws
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) January 20, 2024 19:26
@JorTurFer
Use client region as it manages default values
b1c977b 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member

JorTurFer commented Jan 20, 2024 •
edited by github-actions bot

/run-e2e aws
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) January 20, 2024 19:57
@JorTurFer JorTurFer merged commit a815f06 into kedacore:main Jan 20, 2024
19 checks passed
@JorTurFer JorTurFer mentioned this pull request Feb 13, 2024
Closed
21 tasks
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Feb 29, 2024
@sguruvar @JorTurFer
fix(prometheus-scaler): AWS signv4 parses region if provided (kedacor…
d56ff21 
…e#5421)

Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer JorTurFer mentioned this pull request Feb 29, 2024
Merged
5 tasks
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Feb 29, 2024
@sguruvar @JorTurFer
fix(prometheus-scaler): AWS signv4 parses region if provided (kedacor…
eeae957 
…e#5421)

Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
JorTurFer added a commit that referenced this pull request Feb 29, 2024
@JorTurFer @sguruvar @vinod827
Release v2.13.1 cherry-pick (#5545)
41dd7a8 
* fix(gcp scalers): Restore previous time horizon to fix missing metrics and properly close the connecctions (#5452)

* fix(gcp scalers): Restore previous time horizon to fix missing metrics

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* Close gcp client on scaler closing

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* fix style

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

---------

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* fix(prometheus-scaler): AWS signv4 parses region if provided (#5421)

Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* Fixed the issue#5484 with inaccurate version label in release asset (#5518)

Signed-off-by: Vinod Kumar Nair <vinod827@gmail.com>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* fix: Place the changelog entry in unreleased section (#5519)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* prepare changelog

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

---------

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
Signed-off-by: Vinod Kumar Nair <vinod827@gmail.com>
Co-authored-by: Siva Guruvareddiar <1725781+sguruvar@users.noreply.github.com>
Co-authored-by: Vinod Kumar <24762720+vinod827@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus AMP scaler returning error : "Credential should be scoped to a valid region."
3 participants
@sguruvar @JorTurFer @tomkerkhove