fix(gcp scalers): Restore previous time horizon to fix missing metrics and properly close the connecctions #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
|
/run-e2e gcp |
This was referenced Feb 1, 2024
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
|
/run-e2e gcp |
JorTurFer
changed the title
|
/run-e2e gcp |
zroubalik
reviewed
Feb 12, 2024
zroubalik
approved these changes
Feb 12, 2024
This was referenced Feb 13, 2024
Closed
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Feb 29, 2024
…s and properly close the connecctions (kedacore#5452) * fix(gcp scalers): Restore previous time horizon to fix missing metrics Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Close gcp client on scaler closing Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix style Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Feb 29, 2024
…s and properly close the connecctions (kedacore#5452) * fix(gcp scalers): Restore previous time horizon to fix missing metrics Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Close gcp client on scaler closing Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix style Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
JorTurFer
added a commit
that referenced
this pull request
Feb 29, 2024
* fix(gcp scalers): Restore previous time horizon to fix missing metrics and properly close the connecctions (#5452) * fix(gcp scalers): Restore previous time horizon to fix missing metrics Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Close gcp client on scaler closing Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix style Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix(prometheus-scaler): AWS signv4 parses region if provided (#5421) Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * Fixed the issue#5484 with inaccurate version label in release asset (#5518) Signed-off-by: Vinod Kumar Nair <vinod827@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix: Place the changelog entry in unreleased section (#5519) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * prepare changelog Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com> Signed-off-by: Vinod Kumar Nair <vinod827@gmail.com> Co-authored-by: Siva Guruvareddiar <1725781+sguruvar@users.noreply.github.com> Co-authored-by: Vinod Kumar <24762720+vinod827@users.noreply.github.com>
ArunYogesh
pushed a commit
to ArunYogesh/keda
that referenced
this pull request
Mar 1, 2024
…s and properly close the connecctions (kedacore#5452) * fix(gcp scalers): Restore previous time horizon to fix missing metrics Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Close gcp client on scaler closing Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix style Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before changes in v2.13 related with GCP client, the time horizon for queries was 2m. We changed it by mistake and this PR restores the previous behaviour.
As customizing the value could make sense for different scenarios, I've created another issue to track supporting it (for next version): #5453
Checklist
Fixes #5429
Fixes #5448