[wip] smi scaler #783
Closed
[wip] smi scaler #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2020 23:58
ran `make generate-api` Signed-off-by: adnan <adnan.khan021@gmail.com>
Signed-off-by: adnan <adnan.khan021@gmail.com>
|
will reopen with changes from #787 |
|
@adnxn just be aware that client-go PR is opened for v2 branch, we are about to release KEDA v2 with some changes in ScaledObject and other internal modifications. |
|
@adnxn v2 is based on kubernetes-17.4 so you might want to build your scaler on that. The only downside is that v2 will be release later (my guess is June/July) |
|
right - i think it would make sense to just include those changes and refactor this PR to account for the changes in ScaledObject |
|
I'm wondering if we should use v2 or v1? Wouldn't it make sense to use it for v1 for now and replatting it with the rest or is the effort too high? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #615