This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
replicas set to 0 if not specified #357
Labels
Comments
@kadel the structs we are importing should have |
We are not setting the value anywhere inside the code! |
If there is no other solution than We will have to default to 1 manually. But we have to be careful and correctly recognize if replicas in kedge wasn't set or it was explicitly set to 0 |
concaf
added a commit
to concaf/kedge
that referenced
this issue
Oct 13, 2017
Setting no value for the "replicas" field in a DeploymentConfig sets the value as 0, while we should be setting this value as 1. This commit fixes that. Fixes kedgeproject#357
concaf
added a commit
to concaf/kedge
that referenced
this issue
Oct 13, 2017
Setting no value for the "replicas" field in a DeploymentConfig sets the value as 0, while we should be setting this value as 1. This commit fixes that. Fixes kedgeproject#357
concaf
added a commit
to concaf/kedge
that referenced
this issue
Oct 16, 2017
Setting no value for the "replicas" field in a DeploymentConfig sets the value as 0, while we should be setting this value as 1. This commit fixes that and adds tests for the behavior. Fixes kedgeproject#357
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If replicas is not set in Kedge file, the generated output shouldn't have it either.
Now it defaults to 0, which leads to a confusing situation where your containers are not started when DC id deployed.
replicas shouldn't be set if it's not set in Kedge file, OpenShift default will be used on the cluster side.
The text was updated successfully, but these errors were encountered: