This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
set default replicas as 1 in DeploymentConfig #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concaf
force-pushed
the
fix_replicas_dc
branch
from
876c0d2
to
f8a159a
Compare
|
Needs unit test related to replicas |
Setting no value for the "replicas" field in a DeploymentConfig sets the value as 0, while we should be setting this value as 1. This commit fixes that and adds tests for the behavior. Fixes kedgeproject#357
concaf
force-pushed
the
fix_replicas_dc
branch
from
f8a159a
to
359a377
Compare
|
@surajnarwade added. |
|
LGTM :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting no value for the "replicas" field in a DeploymentConfig
sets the value as 0, while we should be setting this value as 1.
This commit fixes that.
Fixes #357