This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
order artifacts generation #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure apps come up faster the order in which we provide artifacts to cluster does matter. So ordering the artifacts such that non-controllers are first in the list and controllers come up later.
|
@surajssd, thank you for the pull request! We'll ping some people to review your PR. @containscafeine, please review this. |
|
I tried running e2e tests with the binary built on this code, it ran the entire test suite in just 114 seconds where it used to take more than 250 seconds before |
|
for some reason coveralls complains, even though no new code was added in this PR! |
|
ping @kadel |
|
It looks like coveralls is counting also comment lines :-) |
kadel
approved these changes
Aug 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure apps come up faster the order in which we provide artifacts to cluster does matter. So ordering the artifacts such that non-controllers are first in the list and controllers come up later.
Fixes #207