add support for OpenShift Routes #366
Conversation
|
| @@ -65,12 +66,20 @@ func GetScheme() (*runtime.Scheme, error) { | |||
| // Initializing the scheme with the core v1 api | |||
| scheme := api.Scheme | |||
|
|
|||
| // TODO: find a way where we don't have to add all the subsequent schemes | |||
There was a problem hiding this comment.
Why different schema for different controllers?
Using one with everything should be fine or not?
There was a problem hiding this comment.
It's fine, but it'd lead to a huge schema. So this is more of an optimization TODO, does not really matter much right now tbh.
|
ping @kadel @cdrage @surajssd - I've added docs, tests and an example. |
docs/examples/routes/httpd.yml
Outdated
| @@ -0,0 +1,13 @@ | |||
| name: httpd | |||
| containers: | |||
| - image: centos/httpd | |||
There was a problem hiding this comment.
This image uses root,so it can't be run on default openShift configuration :(
There was a problem hiding this comment.
but you could use bitnami/nginx for example
docs/file-reference.md
Outdated
| to: | ||
| kind: Service | ||
| name: httpd | ||
| weight: 100 |
There was a problem hiding this comment.
I would remove weight and wildcardPolicy It just makes it look too complicated
docs/file-reference.md
Outdated
| Example: | ||
| ```yaml | ||
| name: webroute | ||
| host: httpd-web.192.168.42.69.nip.io |
There was a problem hiding this comment.
can we maybe remove host?
It is not required, and if someone tries it like this it won't work
| @@ -225,6 +252,19 @@ func (app *ControllerFields) createIngresses() ([]runtime.Object, error) { | |||
| return ings, nil | |||
| } | |||
|
|
|||
| func (app *ControllerFields) createRoutes() ([]runtime.Object, error) { | |||
There was a problem hiding this comment.
It would be nice to have tests for this function ;-)
This commit adds support for defining OpenShift routes in a Kedge
file.
Routes can be defined like the following at the root level of a
Kedge file
routes:
- name: route1
host: route1-myproject.192.168.42.69.nip.io
port:
targetPort: 8080
to:
kind: Service
name: httpd
This is implemented by essentially merging RouteSpec and ObjectMeta
and adding an array of the resulting struct at the root level under
the field "routes"
Adds docs, tests.
Fixes kedgeproject#238
This commit adds support for defining OpenShift routes in a Kedge
file.
Routes can be defined like the following at the root level of a
Kedge file
This is implemented by essentially merging RouteSpec and ObjectMeta
and adding an array of the resulting struct at the root level under
the field "routes"
Adds docs, tests.
Fixes #238