This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Delete tarball after image builds #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajnarwade
force-pushed
the
del-tarball
branch
from
b83346a
to
5594014
Compare
kadel
suggested changes
Nov 28, 2017
pkg/build/build.go
Outdated
| return errors.Wrap(err, "unable to build image") | ||
| } | ||
|
|
||
| log.Infof("Image '%s' from directory '%s' built successfully", image, path.Base(context)) | ||
| log.Debugf("Image %s build output:\n%s", image, outputBuffer) | ||
|
|
||
| log.Debugf("Deleted temporary file %v", os.Remove(tmpFile.Name())) |
There was a problem hiding this comment.
This will show Deleted temporary file <nil>
os.Remove returns error. You should check it, not printing it.
There was a problem hiding this comment.
This is also nice case for using defer to avoid having to call in two places in case of erro
surajnarwade
force-pushed
the
del-tarball
branch
from
5594014
to
726d213
Compare
|
@kadel , got it, updated the code :) |
kadel
suggested changes
Nov 28, 2017
pkg/build/build.go
Outdated
| @@ -99,14 +99,15 @@ func (c *Build) BuildImage(dockerfile, image, context string) error { | |||
| Dockerfile: dockerfile, | |||
| } | |||
|
|
|||
| // Delete tarball after creating image | |||
| defer os.Remove(tmpFile.Name()) | |||
There was a problem hiding this comment.
defer should be placed right after tmpFile is created. Otherwise, it won't be run before for any return between this and tmpFile, err := ioutil.TempFile("/tmp", "kedge-image-build-")
surajssd
reviewed
Nov 28, 2017
pkg/build/build.go
Outdated
| // Build it! | ||
| if err := c.Client.BuildImage(opts); err != nil { | ||
| return errors.Wrap(err, "unable to build image") | ||
| } | ||
|
|
There was a problem hiding this comment.
@surajnarwade : unrelated changes!
surajnarwade
force-pushed
the
del-tarball
branch
from
726d213
to
d507503
Compare
Resolves kedgeproject#488, This PR will delete temporary files created in `/tmp` for building images with `kedge build`
surajnarwade
force-pushed
the
del-tarball
branch
from
d507503
to
0993391
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #488, This PR will delete temporary files created in
/tmpfor building images with
kedge build