This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
add basic test framework for cmd line tests #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@surajssd I believe you need to do a vendor update to grab that one package you added 👍 |
cdrage
approved these changes
Dec 4, 2017
tests/cmd/cmd_test.go
Outdated
| } | ||
|
|
||
| func runCmd(t *testing.T, args []string) (string, error) { | ||
| cmd := exec.Command("kedge", args...) |
There was a problem hiding this comment.
might be good to make kedge a global variable just-in-case we port this code to another project (hint: kompose, haha)
surajssd
force-pushed
the
cmd-test-framework
branch
2 times, most recently
from
1a322b2
to
e869e69
Compare
kadel
reviewed
Dec 11, 2017
tests/cmd/cmd_test.go
Outdated
| }{ | ||
| { | ||
| name: "multiple configmaps given and name not specified", | ||
| command: []string{"generate", "-f=" + Fixtures + "multi-configmapname/app.yaml"}, |
There was a problem hiding this comment.
this test just generates an all the files are always in Fixtures dir.
It would be more readable to specify just file/dir path.
testCases := []struct {
name string
path string
input string
wantSuccess bool
error string
}{
{
name: "multiple configmaps given and name not specified",
path: "multi-configmapname/app.yaml"
...proper command can be build inside for loop before test is run
surajssd
force-pushed
the
cmd-test-framework
branch
2 times, most recently
from
8fb9002
to
2d0cd9c
Compare
surajssd
force-pushed
the
cmd-test-framework
branch
from
2d0cd9c
to
60c048b
Compare
surajssd
force-pushed
the
cmd-test-framework
branch
from
60c048b
to
d67059e
Compare
surajssd
force-pushed
the
cmd-test-framework
branch
from
d67059e
to
451f30d
Compare
kadel
approved these changes
Jan 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.