-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CircleCI setup #4
Conversation
d3ea82d
to
db247a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looking through the PR, will continue reviewing tomorrow! So far looks really great though 👍 👍
Overall this looks awesome! I was expecting something that was an MVP but this looks pretty close to an ideal solution, amazing work! Love the use of the matrix and parameters and all that - really pleased to see we can do per-directory selective workflows without too much faff. 🎉 In addition to my many minor comments, there's a few other things I think we should still consider (not necessarily in this PR). pip freezeMight be nice to add a TestingBy pushing to this branch and making sure only the right workflows run, making sure that the environment has the right requirements file installed (e.g. using How to deal with pre-commitDo the pre-commit hooks actually still work without the file being at the root of the repo? My guess based on this is maybe not 🤔 How to deal with MakefileI'm not sure whether the Makefile should be per-project or at the repo root. It's definitely less repetitive the way you've done it, but when I'm working on a single plugin I would sort of expect the Makefile to live inside the directory for that individual plugin. Kind of like how each plugin has its own .pre-commit-config.yaml, pyproject.toml etc. How to deal with parameters3 boolean parameters like
The advantage of this is you might then need a only single workflow that works for all 3 plugins instead of needing to switch between 3 different workflows dependent on the boolean:
Related to this we are doing
And then you can call Edit: just thought of a problem with this suggestion... What happens if I modify both telemetry and docker at the same time? I guess we need the 3 boolean variables so we can trigger workflows for multiple plugins simultaneously if required 🤔 |
c353405
to
5ec0b2d
Compare
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com> Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
59a4785
to
2b4e9a0
Compare
This PR is the complete set of changes required to have CCI builds for all plugins in
kedro-plugins
.It has the changes from #2 with the addition of
path-filtering
which allows you to only run builds for the parts of the repo that have changed. I followed the steps here to get this to work.I'll mark #2 as
draft
so you can use it as a reference how I came to the changes here, but I will only be merging be this PR.