Add spaceflights-pyspark starter
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
merelcht
commented
Sep 15, 2023
spaceflights-pyspark/README.md
Outdated
Comment on lines
11
to
15
| ```bash | ||
| pip install kedro | ||
| kedro new --starter=spaceflights-pyspark | ||
| cd <my-project-name> # change directory into newly created project directory | ||
| ``` |
There was a problem hiding this comment.
Do we want to keep this explanation or remove this from the new starters? @amandakys
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
…labs/kedro-starters into create-spaceflights-pyspark
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
|
Will this be introduced before 0.19? |
noklam
reviewed
Sep 25, 2023
noklam
reviewed
Sep 25, 2023
noklam
reviewed
Sep 25, 2023
spaceflights-pyspark/{{ cookiecutter.repo_name }}/conf/README.md
Outdated
Show resolved
Hide resolved
| return companies | ||
|
|
||
|
|
||
| def load_shuttles_to_csv(shuttles: pd.DataFrame) -> pd.DataFrame: |
There was a problem hiding this comment.
The original data is in excel format. If I don't add this node, how would it be turned into csv?
Comment on lines
23
to
29
| class TestDataScienceNodes: | ||
| def test_split_data(self, dummy_data, dummy_parameters): | ||
| X_train, X_test, y_train, y_test = split_data(dummy_data, dummy_parameters["model_options"]) | ||
| assert len(X_train) == 2 | ||
| assert len(X_test) == 1 | ||
| assert len(y_train) == 2 | ||
| assert len(y_test) == 1 |
There was a problem hiding this comment.
⭐️ I like that we are adding some example for tests.
There was a problem hiding this comment.
Do you think the test is good enough or should it be more meaningful and also test spark stuff?
stichbury
reviewed
Sep 25, 2023
stichbury
approved these changes
Sep 25, 2023
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
merelcht
commented
Sep 26, 2023
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Co-authored-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
…labs/kedro-starters into create-spaceflights-pyspark
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
merelcht
commented
Sep 27, 2023
|
I took a quick look and it's fine. I don't have time to test it out, it's best to have another engineer to approve this maybe @AhdraMeraliQB ? |
SajidAlamQB
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Tested it manually and all looks good. Thank you @merelcht! 👍
spaceflights-pyspark/{{ cookiecutter.repo_name }}/conf/base/parameters_data_science.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
…labs/kedro-starters into create-spaceflights-pyspark
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
kedro-org/kedro#2984 subtask of kedro-org/kedro#2838 which in turn is part of the new project creation flow.
How has this been tested?
Created a project locally using:
kedro new --starter=/Users/merel_theisen/Projects/kedro-starters/spaceflights-pyspark/and didkedro runThings to note:
logging.ymloutside of thebasefolder to the top-levelconf/folderTestDataScienceNodesto demonstrate how you can write a unit test for a node.Questions:
kedro new --starter=spaceflights-pyspark?Checklist