New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/remove tags from panel #1100
Conversation
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working through this! Sorry the original BE change didn't work out as expected but I hope it was educational anyway 🙈
no worries at all. it was a good learning to make changes from the BE side :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Approving now with a question: do we still have a test that checks if the tags are shown? The two you changed are checking that they're not there. If there isn't a test to check if they do exists maybe you could add one?
Signed-off-by: huongg <huongg1409@gmail.com>
hey @tynandebold yup we already have a test for tags, specifically for TaskNode only
|
Co-authored-by: Tynan DeBold <thdebold@gmail.com>
Description
Fixes #1092
Development notes
This fix is to only show the tags field from the frontend if it's a task node. We won't remove it from the BE as it will impact the flowchart logic. You can find the conversation here which we discussed specifically about how it would impact the flowchart
If we're all happy with this fix, we can close the PR 1099, which include changes from BE
Checklist
RELEASE.md
file