Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove tags from panel #1100

Merged
merged 5 commits into from
Sep 27, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Please follow the established format:
- Fix pretty naming for transcoded datasets. (#1062)
- Keep graph visible when switching pipelines. (#1063)
- Add a transition to run details in experiment tracking. (#1065)
- Remove tags field from datasets and parameters in flowchart panel. (#1100)
Huongg marked this conversation as resolved.
Show resolved Hide resolved

# Release 5.1.1

Expand Down
14 changes: 8 additions & 6 deletions src/components/metadata/metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -190,12 +190,14 @@ const MetaData = ({
visible={isTaskNode}
value={metadata.outputs}
/>
<MetaDataRow
label="Tags:"
kind="token"
commas={false}
value={metadata.tags}
/>
{metadata.type === 'task' && (
<MetaDataRow
label="Tags:"
kind="token"
commas={false}
value={metadata.tags}
/>
)}
<MetaDataRow label="Run Command:" visible={Boolean(runCommand)}>
<CommandCopier command={runCommand} />
</MetaDataRow>
Expand Down
8 changes: 4 additions & 4 deletions src/components/metadata/metadata.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -309,13 +309,13 @@ describe('MetaData', () => {
]);
});

it('shows the node tags', () => {
it('wont show any tags as they should only appear if the type is nodeTask', () => {
const wrapper = mount({
nodeId: modelInputDataSetNodeId,
mockMetadata: nodeData,
});
const row = rowByLabel(wrapper, 'Tags:');
expect(textOf(rowValue(row))).toEqual(['Features', 'Split']);
expect(row.length).toBe(0);
});

describe('when there is a runCommand returned by the backend', () => {
Expand Down Expand Up @@ -487,13 +487,13 @@ describe('MetaData', () => {
);
});

it('shows the node tags', () => {
it('wont show any tags as they should only appear if the type is nodeTask', () => {
const wrapper = mount({
nodeId: parametersNodeId,
mockMetadata: nodeParameters,
});
const row = rowByLabel(wrapper, 'Tags:');
expect(textOf(rowValue(row))).toEqual(['Split']);
expect(row.length).toBe(0);
});
});

Expand Down