Make shareable URL modal open globally across the app. #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidakanchwala
requested review from
jitu5 and
ravi-kumar-pilla
and removed request for
tynandebold and
yetudada
| @@ -51,6 +53,8 @@ export const Wrapper = ({ displayGlobalToolbar, theme }) => { | |||
| isOutdated={isOutdated} | |||
| latestVersion={latestVersion} | |||
| /> | |||
| {isRunningLocally() ? null : <ShareableUrlMetadata />} | |||
| {isRunningLocally() ? <ShareableUrlModal /> : null} | |||
ravi-kumar-pilla
approved these changes
Nov 15, 2023
rashidakanchwala
added a commit
that referenced
this pull request
Nov 17, 2023
This is minor release with big backend refactoring work and some bug fixes. Bug fixes and other changes Refactor flowchart dataclasses to pydantic base models. (Refactor Flowchart models from dataclass to pydantic base models #1565) Fix dataset factory patterns in Experiment Tracking. (Fix dataset factory patterns in Experiment Tracking #1588) Update demo-project to use OmegaConfigLoader. (Update demo project to use OmegaConfigLoader #1590) Improve feedback for copy to clipboard feature. (Add tooltip to shareable urls copy button #1614) Ensure Kedro-Viz works when hosted on a URL subpath. (Fix: Kedro-Viz doesn't work when hosted via a URL subpath #1621) Bump fastapi upper bounds. (Bump FAST API upper bounds #1634) Fix shareable URL modal to appear across the app. (Make shareable URL modal open globally across the app. #1639) Add Kedro-Viz CLI command deprecation warning. (Add kedro viz deprecation warning for CLI #1641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1633
QA
I tested publishing via modal when on Experiment Tracking page; it worked fine. However, I had to undo @ravi-kumar-pilla's last commit on main and try it because 'publish' is broken with the new BE refactor.
Checklist
RELEASE.mdfile