Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shareable URL modal open globally across the app. #1639

Merged
merged 5 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Please follow the established format:
- Fix dataset factory patterns in Experiment Tracking. (#1588)
- Improved feedback for copy to clipboard feature. (#1614)
- Ensure Kedro-Viz works when hosted on a URL subpath. (#1621)
- Fix shareable URL modal to appear across the app. (#1639)
- Refactor flowchart dataclasses to pydantic base models. (#1565)

# Release 6.6.1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ describe('Experiment Tracking', () => {
});

// Action
cy.get('[data-test="kedro-pipeline-selector"]').click();
cy.get('.select-dropdown [data-test="kedro-pipeline-selector"]').click();
cy.get('.dropdown__options > :nth-child(2)').click();
cy.get('[data-test="btnMetricsChange"]').click();

Expand Down Expand Up @@ -170,7 +170,7 @@ describe('Experiment Tracking', () => {
.and('eq', plotToCheckText);

// Action
cy.get('[data-test="kedro-pipeline-selector"]').click();
cy.get('.select-dropdown [data-test="kedro-pipeline-selector"]').click();
cy.get('.dropdown__options > :nth-child(2)').click();
cy.get('[data-test="btnMetricsChange"]').click();

Expand Down
5 changes: 0 additions & 5 deletions src/components/flowchart-wrapper/flowchart-wrapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ import PipelineWarning from '../pipeline-warning';
import LoadingIcon from '../icons/loading';
import MetaData from '../metadata';
import MetadataModal from '../metadata-modal';
import ShareableUrlModal from '../shareable-url-modal';
import ShareableUrlMetadata from '../shareable-url-modal/shareable-url-metadata';
import Sidebar from '../sidebar';
import Button from '../ui/button';
import CircleProgressBar from '../ui/circle-progress-bar';
Expand All @@ -35,7 +33,6 @@ import {
} from '../../config';
import { findMatchedPath } from '../../utils/match-path';
import { getKeyByValue } from '../../utils/get-key-by-value';
import { isRunningLocally } from '../../utils';

import './flowchart-wrapper.scss';

Expand Down Expand Up @@ -297,11 +294,9 @@ export const FlowChartWrapper = ({
>
<LoadingIcon visible={loading} />
</div>
{isRunningLocally() ? null : <ShareableUrlMetadata />}
</div>
<ExportModal />
<MetadataModal />
{isRunningLocally() ? <ShareableUrlModal /> : null}
</div>
);
}
Expand Down
4 changes: 4 additions & 0 deletions src/components/wrapper/wrapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import FlowChartWrapper from '../flowchart-wrapper';
import ExperimentWrapper from '../experiment-wrapper';
import SettingsModal from '../settings-modal';
import UpdateReminder from '../update-reminder';
import ShareableUrlModal from '../shareable-url-modal';
import ShareableUrlMetadata from '../shareable-url-modal/shareable-url-metadata';

import './wrapper.scss';

Expand Down Expand Up @@ -51,6 +53,8 @@ export const Wrapper = ({ displayGlobalToolbar, theme }) => {
isOutdated={isOutdated}
latestVersion={latestVersion}
/>
{isRunningLocally() ? null : <ShareableUrlMetadata />}
{isRunningLocally() ? <ShareableUrlModal /> : null}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool !

{versionData && (
<UpdateReminder
isOutdated={isOutdated}
Expand Down