-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-3049] Update contributors guide to include guidance on DCO #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
antonymilne
changed the title
Docs/update contributing dco#ked 3049
[KED-3049] Update contributors guide to include guidance on DCO
Jan 24, 2022
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
antonymilne
requested review from
tynandebold,
rashidakanchwala and
studioswong
January 24, 2022 16:55
…-3049' into docs/update-contributing-dco#ked-3049
rashidakanchwala
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM!
studioswong
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work for setting up the docs and the sign off workfow 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per kedro-org/kedro#1167 and kedro-org/kedro#1177, now that we're part of LF, we need all commits to be signed-off. I'm not a fan of this, but after spending far too much time on it I've come up with this workflow as the simplest possible one for now.
make sign-off
: this creates a git hook that will add the Signed-off-by line to all commit message. This is a better solution than aliasing git commit for various reasonsrequire: members: false
for the DCO GitHub app configuration. This means that signed commits (i.e. GPG or S/MIME signed, not signed-off) by members of kedro-org do not need to have the Signed-off-by line. In practice, this is very helpful because it means that any commits maintainers make on GitHub (applying code review suggestions, merging inmain
, etc.) will get ✅ for DCO check.Possible future improvements
allowRemediationCommits
to make it easier for users to retroactively sign off commitsChecklist
RELEASE.md
file