Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the upper bound for Flake8 dependency to <5.0 #1594

Merged
merged 12 commits into from
Jun 14, 2022
Merged

Bump the upper bound for Flake8 dependency to <5.0 #1594

merged 12 commits into from
Jun 14, 2022

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Jun 7, 2022 •
edited
Loading

Signed-off-by: Deepyaman Datta deepyaman.datta@utexas.edu

Description

Development notes

Pending #1595 (as is any other code PR).

FYI relaxed the importlib_metadata lower bound to be compatible with https://github.com/PyCQA/flake8/blob/c6882772e1640ff4c59f6d84986377813cf9236a/setup.cfg#L45.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@deepyaman
Bump the upper bound for Flake8 dependency to <5.0
1133487 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Update requirements.txt
b0d51c7 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Update tutorial_template.md
b7c33d0 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Merge branch 'main' into patch-5
b6fa610
@deepyaman deepyaman marked this pull request as ready for review June 8, 2022 11:14
@deepyaman deepyaman marked this pull request as draft June 8, 2022 11:19
@deepyaman
Relax the importlib_metadata req for compatibility
940ffa3 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
deepyaman commented Jun 8, 2022
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@deepyaman
Use importlib_metadata regardless of Python version
3113a82 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman marked this pull request as ready for review June 8, 2022 23:55
@deepyaman
Copy link
Member Author

deepyaman commented Jun 8, 2022 •
edited
Loading

No idea what broke the import-linter build on Windows using 3.10, as the issue also manifests in 940ffa3, which is without the importlib_metadata import altogether.

Furthermore, version of importlib_metadata should be the same here as it is on main...

JK, I see nothing wrong here...

@deepyaman
Update RELEASE.md
17ffe00 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
merelcht
merelcht approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but other than that happy to have this merged! 😃

requirements.txt Show resolved Hide resolved
@merelcht merelcht requested a review from noklam June 13, 2022 10:59
@merelcht merelcht merged commit 15d47c7 into kedro-org:main Jun 14, 2022
@astrojuanlu astrojuanlu mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noklam noklam noklam approved these changes

@merelcht merelcht merelcht approved these changes

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

@idanov idanov Awaiting requested review from idanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deepyaman @noklam @merelcht